diff --git a/minimalkv/net/s3fsstore.py b/minimalkv/net/s3fsstore.py index c72ad5b..daeed30 100644 --- a/minimalkv/net/s3fsstore.py +++ b/minimalkv/net/s3fsstore.py @@ -184,13 +184,11 @@ def _from_parsed_url( if url_access_key_id is None: url_secret_access_key = os.environ.get("AWS_ACCESS_KEY_ID") - else: - os.environ["AWS_ACCESS_KEY_ID"] = url_access_key_id + # TODO: Should we allow these attributes to be none-able? + # A potential use case might be a public bucket if url_secret_access_key is None: url_secret_access_key = os.environ.get("AWS_SECRET_ACCESS_KEY") - else: - os.environ["AWS_SECRET_ACCESS_KEY"] = url_secret_access_key credentials = Credentials( access_key_id=url_access_key_id,