diff --git a/frontend/src/modules/Folders/components/FolderOverview.js b/frontend/src/modules/Folders/components/FolderOverview.js index 48464ca86..fb5c508d5 100644 --- a/frontend/src/modules/Folders/components/FolderOverview.js +++ b/frontend/src/modules/Folders/components/FolderOverview.js @@ -23,12 +23,14 @@ export const FolderOverview = (props) => { } /> - + {folder.restricted && ( + + )} { S3 URI - {`s3://${folder.restricted?.S3BucketName || 'UNAUTHORIZED_INFO'}/${ - folder.S3Prefix - }/`} + {`s3://${folder.restricted.S3BucketName}/${folder.S3Prefix}/`} @@ -29,9 +27,7 @@ export const FolderS3Properties = (props) => { S3 ARN - {`arn:aws:s3:::${ - folder.restricted?.S3BucketName || 'UNAUTHORIZED_INFO' - }/${folder.S3Prefix}/`} + {`arn:aws:s3:::${folder.restricted.S3BucketName}/${folder.S3Prefix}/`} @@ -39,7 +35,7 @@ export const FolderS3Properties = (props) => { Region - {folder.restricted?.region || 'UNAUTHORIZED_INFO'} + {folder.restricted.region} @@ -47,7 +43,7 @@ export const FolderS3Properties = (props) => { Account - {folder.restricted?.AwsAccountId || 'UNAUTHORIZED_INFO'} + {folder.restricted.AwsAccountId} diff --git a/frontend/src/modules/S3_Datasets/components/DatasetConsoleAccess.js b/frontend/src/modules/S3_Datasets/components/DatasetConsoleAccess.js index 7e6a6d5c1..d24dca471 100644 --- a/frontend/src/modules/S3_Datasets/components/DatasetConsoleAccess.js +++ b/frontend/src/modules/S3_Datasets/components/DatasetConsoleAccess.js @@ -19,7 +19,7 @@ export const DatasetConsoleAccess = (props) => { Account - {dataset.restricted?.AwsAccountId || 'UNAUTHORIZED_INFO'} + {dataset.restricted.AwsAccountId} @@ -28,7 +28,7 @@ export const DatasetConsoleAccess = (props) => { arn:aws:s3::: - {dataset.restricted?.S3BucketName || 'UNAUTHORIZED_INFO'} + {dataset.restricted.S3BucketName} @@ -36,11 +36,7 @@ export const DatasetConsoleAccess = (props) => { Glue database - {`arn:aws:glue:${dataset.restricted?.region || 'UNAUTHORIZED_INFO'}:${ - dataset.restricted?.AwsAccountId || 'UNAUTHORIZED_INFO' - }/database:${ - dataset.restricted?.GlueDatabaseName || 'UNAUTHORIZED_INFO' - }`} + {`arn:aws:glue:${dataset.restricted.region}:${dataset.restricted.AwsAccountId}/database:${dataset.restricted.GlueDatabaseName}`} @@ -48,32 +44,29 @@ export const DatasetConsoleAccess = (props) => { IAM role - {dataset.restricted?.IAMDatasetAdminRoleArn || 'UNAUTHORIZED_INFO'} + {dataset.restricted.IAMDatasetAdminRoleArn} - {dataset.restricted && - (dataset.restricted?.KmsAlias === 'SSE-S3' || - dataset.restricted?.KmsAlias === 'Undefined' ? ( - - - S3 Encryption - - - {`${dataset.restricted?.KmsAlias || 'UNAUTHORIZED_INFO'}`} - - - ) : dataset.restricted?.KmsAlias !== '' ? ( - - - S3 Encryption SSE-KMS - - - {`arn:aws:kms:${dataset.restricted.region}:${dataset.restricted.AwsAccountId}/alias:${dataset.restricted.KmsAlias}`} - - - ) : ( - '' - ))} + {dataset.restricted.KmsAlias === 'SSE-S3' || + dataset.restricted.KmsAlias === 'Undefined' ? ( + + + S3 Encryption + + + {`${dataset.restricted.KmsAlias}`} + + + ) : ( + + + S3 Encryption SSE-KMS + + + {`arn:aws:kms:${dataset.restricted.region}:${dataset.restricted.AwsAccountId}/alias:${dataset.restricted.KmsAlias}`} + + + )} ); }; diff --git a/frontend/src/modules/S3_Datasets/components/DatasetOverview.js b/frontend/src/modules/S3_Datasets/components/DatasetOverview.js index 351e8a3ce..33df3e18c 100644 --- a/frontend/src/modules/S3_Datasets/components/DatasetOverview.js +++ b/frontend/src/modules/S3_Datasets/components/DatasetOverview.js @@ -33,7 +33,9 @@ export const DatasetOverview = (props) => { objectType="dataset" /> - {isAdmin && } + {isAdmin && dataset.restricted && ( + + )} diff --git a/frontend/src/modules/S3_Datasets/components/DatasetStartCrawlerModal.js b/frontend/src/modules/S3_Datasets/components/DatasetStartCrawlerModal.js index ae673d182..8196760fc 100644 --- a/frontend/src/modules/S3_Datasets/components/DatasetStartCrawlerModal.js +++ b/frontend/src/modules/S3_Datasets/components/DatasetStartCrawlerModal.js @@ -132,10 +132,7 @@ export const DatasetStartCrawlerModal = (props) => { error={Boolean(touched.prefix && errors.prefix)} fullWidth helperText={touched.prefix && errors.prefix} - label={`s3://${ - dataset.restricted?.S3BucketName || - 'UNAUTHORIZED_INFO' - }/`} + label={`s3://${dataset.restricted.S3BucketName}/`} name="prefix" onBlur={handleBlur} onChange={handleChange} diff --git a/frontend/src/modules/S3_Datasets/components/DatasetUpload.js b/frontend/src/modules/S3_Datasets/components/DatasetUpload.js index ad45d48b5..28398fcd4 100644 --- a/frontend/src/modules/S3_Datasets/components/DatasetUpload.js +++ b/frontend/src/modules/S3_Datasets/components/DatasetUpload.js @@ -153,9 +153,7 @@ export const DatasetUpload = (props) => { { terms: dataset.terms || [], stewards: dataset.stewards, confidentiality: dataset.confidentiality, - KmsAlias: dataset.restricted?.KmsAlias || 'UNAUTHORIZED_INFO', + KmsAlias: dataset.restricted.KmsAlias, autoApprovalEnabled: dataset.autoApprovalEnabled, expirationSetting: dataset.expirySetting, minValidity: dataset.expiryMinDuration, diff --git a/frontend/src/modules/Worksheets/views/WorksheetView.js b/frontend/src/modules/Worksheets/views/WorksheetView.js index e2e87c701..f3c409aef 100644 --- a/frontend/src/modules/Worksheets/views/WorksheetView.js +++ b/frontend/src/modules/Worksheets/views/WorksheetView.js @@ -136,7 +136,7 @@ const WorksheetView = () => { (d) => ({ ...d, value: d.datasetUri, - label: d.restricted?.GlueDatabaseName || 'UNAUTHORIZED_INFO' + label: d.restricted.GlueDatabaseName }) ); } @@ -198,7 +198,7 @@ const WorksheetView = () => { response.data.getDataset.tables.nodes.map((t) => ({ ...t, value: t.tableUri, - label: t.restricted?.GlueTableName || 'UNAUTHORIZED_INFO' + label: t.restricted.GlueTableName })) ); } else { @@ -381,7 +381,7 @@ const WorksheetView = () => { setSqlBody( `SELECT * FROM "${selectedDatabase.label}"."${ event.target.value.restricted - ? event.target.value.restricted?.GlueTableName || 'UNAUTHORIZED_INFO' + ? event.target.value.restricted.GlueTableName : event.target.value.GlueTableName }" limit 10;` );