From 1f625f260b8d39e79511f28ded073cf795f17196 Mon Sep 17 00:00:00 2001 From: Noah Paige <69586985+noah-paige@users.noreply.github.com> Date: Fri, 15 Nov 2024 05:58:21 -0500 Subject: [PATCH] return EnvironmentLogsBucketName from integraiton test getEnv query (#1697) ### Feature or Bugfix - Bugfix ### Detail - Fix integration test teardown of environment bug on cleaning up EnvironmentLogsBucketName ### Relates - #1695 ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --- backend/dataall/core/environment/cdk/environment_stack.py | 1 + tests_new/integration_tests/core/environment/queries.py | 1 + 2 files changed, 2 insertions(+) diff --git a/backend/dataall/core/environment/cdk/environment_stack.py b/backend/dataall/core/environment/cdk/environment_stack.py index cf6529a68..df6c8cc17 100644 --- a/backend/dataall/core/environment/cdk/environment_stack.py +++ b/backend/dataall/core/environment/cdk/environment_stack.py @@ -610,6 +610,7 @@ def create_integration_tests_role(self): 'arn:aws:s3:::dataall-test-session*/*', 'arn:aws:s3:::dataall-temp*', 'arn:aws:s3:::dataall-temp*/*', + 'arn:aws:s3:::dataall-env-access-logs*', ], ) ) diff --git a/tests_new/integration_tests/core/environment/queries.py b/tests_new/integration_tests/core/environment/queries.py index 7a1e3eba2..57608057d 100644 --- a/tests_new/integration_tests/core/environment/queries.py +++ b/tests_new/integration_tests/core/environment/queries.py @@ -11,6 +11,7 @@ tags SamlGroupName EnvironmentDefaultBucketName +EnvironmentLogsBucketName EnvironmentDefaultIAMRoleArn EnvironmentDefaultIAMRoleName EnvironmentDefaultIAMRoleImported