From b9089262f3989baacec3f3e43dbfe7ebaece4561 Mon Sep 17 00:00:00 2001 From: data-bomb Date: Wed, 8 May 2024 20:31:03 -0700 Subject: [PATCH] Stop Disjointed End of Game Conditions - Mod intended to prevent a loss when an HQ was under construction - Mod did this correctly, BUT the game clients were also doing the same loss calculation (independent of the server), leading to some comically bad scenarios where music keeps playing endlessly and the game gets stuck because the server doesn't want the round to end but the clients do - Workaround for #40 is to temporarily remove this functionality from the mods until a better solution is found --- Si_HQlessHumansLose/Si_HQlessHumansLose.cs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Si_HQlessHumansLose/Si_HQlessHumansLose.cs b/Si_HQlessHumansLose/Si_HQlessHumansLose.cs index dbf0504..eabb0f8 100644 --- a/Si_HQlessHumansLose/Si_HQlessHumansLose.cs +++ b/Si_HQlessHumansLose/Si_HQlessHumansLose.cs @@ -33,7 +33,7 @@ You should have received a copy of the GNU General Public License using System; using SilicaAdminMod; -[assembly: MelonInfo(typeof(HQlessHumansLose), "HQless Humans Lose", "1.3.3", "databomb", "https://github.com/data-bomb/Silica")] +[assembly: MelonInfo(typeof(HQlessHumansLose), "HQless Humans Lose", "1.3.4", "databomb", "https://github.com/data-bomb/Silica")] [assembly: MelonGame("Bohemia Interactive", "Silica")] [assembly: MelonOptionalDependencies("Admin Mod")] @@ -257,6 +257,8 @@ private static void Postfix(ConstructionSite __instance, bool __0) } // don't let the structure count reach 0 if HQ/Nest is under construction + // disabled for now because the game clients independently calculate the end of game conditions (not just the server) :( + #if false #if NET6_0 [HarmonyPatch(typeof(Team), nameof(Team.UpdateMajorStructuresCount))] #else @@ -360,7 +362,7 @@ public static void Postfix(Team __instance, ref bool __result) } } } - + #endif #if NET6_0 [HarmonyPatch(typeof(ConstructionSite), nameof(ConstructionSite.Update))]