Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): optional jobs must report success to merge PR #993

Merged
merged 11 commits into from
Dec 12, 2024
Merged

build(ci): optional jobs must report success to merge PR #993

Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e51a523
build(ci): report status of optional jobs
lklimek Dec 9, 2024
6c4b935
chore: revert old approach
lklimek Dec 9, 2024
bbeab11
check-proto, check-mocks
lklimek Dec 9, 2024
9af716e
chore: remove paths
lklimek Dec 9, 2024
2e958fc
build: replace on pull request paths with technote-space/get-diff-act…
lklimek Dec 9, 2024
9bb0ff4
chore: setup go later
lklimek Dec 9, 2024
9b4febd
chore: trigger ci
lklimek Dec 9, 2024
3465528
chore: trigger tests
lklimek Dec 9, 2024
5d15d64
chore: remove fetch-depth to ensure CI will run correctly
lklimek Dec 9, 2024
f18a8c5
chore: remove duplicate code
lklimek Dec 10, 2024
9b47506
check generated mocks when something (incl mockery version) changes i…
lklimek Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .github/workflows/check-generated.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
name: Check generated code
on:
pull_request:
paths:
- "**.go"
- "**.proto"
push:
branches:
- master
Expand All @@ -26,8 +23,16 @@ jobs:
go-version: "1.23.2"

- uses: actions/checkout@v4
with:
fetch-depth: 1 # we need a .git directory to run git diff

- uses: technote-space/get-diff-action@v6
with:
PATTERNS: |
**/*.go

- name: "Check generated mocks"
if: env.GIT_DIFF
run: |
set -euo pipefail

Expand Down Expand Up @@ -55,7 +60,13 @@ jobs:
with:
fetch-depth: 1 # we need a .git directory to run git diff

- uses: technote-space/get-diff-action@v6
with:
PATTERNS: |
**/*.proto

- name: "Check protobuf generated code"
if: env.GIT_DIFF
run: |
set -euo pipefail

Expand Down
Loading