Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support ConsensusParams.VersionParams.consensus_version from Tenderdash 1.3 #101

Merged
merged 2 commits into from
Sep 19, 2024
Merged

feat: support ConsensusParams.VersionParams.consensus_version from Tenderdash 1.3 #101

merged 2 commits into from
Sep 19, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Sep 19, 2024

Issue being fixed or feature implemented

Tenderdash 1.3 includes new .tendermint.types.VersionParams.consensus_version field, and ABCI version 1.2.0.

What was done?

  • Bumped Tenderdash to 1.3.
  • Added new field consensus_version as quoted.
  • Improved release script and docs.

How Has This Been Tested?

Integrated into Dash Platform.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek modified the milestones: 1.2, 1.3 Sep 19, 2024
@lklimek lklimek force-pushed the feat/consensus-params-version branch from c6902e5 to 22e16d6 Compare September 19, 2024 11:29
@lklimek lklimek force-pushed the feat/consensus-params-version branch from 2314d9b to 86bf7f9 Compare September 19, 2024 11:44
shumkov
shumkov approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit e44d25c into develop Sep 19, 2024
18 checks passed
@lklimek lklimek deleted the feat/consensus-params-version branch September 19, 2024 11:46
lklimek added a commit that referenced this pull request Sep 19, 2024
@lklimek
feat: support ConsensusParams.VersionParams.consensus_version from Te…
5c10a1b 
…nderdash 1.3 (#101)

* chore: add consensus_version to consensus params version

* build(deps): update deprecated actions/upload-artifact v1 to v4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantumExplorer QuantumExplorer QuantumExplorer approved these changes

@shumkov shumkov shumkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Platform team
Archived in project
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@lklimek @shumkov @QuantumExplorer