feat(rs-drive-abci)!: commit and vote extensions signature verification #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lklimek
changed the title
lklimek
changed the title
…commit-validation
…commit-validation
…commit-validation
lklimek
changed the title
lklimek
changed the title
QuantumExplorer
requested changes
Apr 17, 2023
| @@ -150,7 +150,7 @@ pub struct PlatformConfig { | |||
| pub verify_sum_trees: bool, | |||
|
|
|||
| /// The default quorum type | |||
| pub quorum_type: QuorumType, | |||
| pub quorum_type: String, | |||
There was a problem hiding this comment.
Why have this as a String?
There was a problem hiding this comment.
because there is a bug in envy / serde, and flattened structs don't deserialize correctly into enums, ints, etc. softprops/envy#26
Comment on lines
+416
to
+423
| let validation_result = received_withdrawals.verify_signatures( | ||
| &self.config.abci.chain_id, | ||
| self.config.quorum_type(), | ||
| quorum_hash, | ||
| height, | ||
| round, | ||
| validator_public_key, | ||
| ); |
There was a problem hiding this comment.
I think this should return a validation result instead of a result
There was a problem hiding this comment.
Returning SimpleValidationResult, moved part of logic to received_withdrawals.verify_signatures
QuantumExplorer
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We want to check if digital signatures returned by Tednerdash are valid.
What was done?
How Has This Been Tested?
Added unit tests that test vectors generated in Tenderdash
Breaking Changes
Added new configuration option: CHAIN_ID
Checklist:
For repository code-owners and collaborators only