Skip to content

feat: runtime versioning #557

feat: runtime versioning

feat: runtime versioning #557

GitHub Actions / clippy failed Jul 10, 2024 in 0s

clippy

3 errors, 19 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 3
Warning 19
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check warning on line 3 in grovedb/src/debugger.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `net::Ipv4Addr`

warning: unused import: `net::Ipv4Addr`
 --> grovedb/src/debugger.rs:3:15
  |
3 | use std::{fs, net::Ipv4Addr, sync::Weak};
  |               ^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Check failure on line 132 in grovedb/src/debugger.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

cannot find value `grove_version` in this scope

error[E0425]: cannot find value `grove_version` in this scope
   --> grovedb/src/debugger.rs:132:63
    |
132 |     let grovedb_element = crate::Element::deserialize(&value, grove_version)?;
    |                                                               ^^^^^^^^^^^^^ not found in this scope

Check failure on line 110 in grovedb/src/debugger.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

cannot find value `grove_version` in this scope

error[E0425]: cannot find value `grove_version` in this scope
   --> grovedb/src/debugger.rs:110:74
    |
110 |         .open_non_transactional_merk_at_path(SubtreePath::empty(), None, grove_version)
    |                                                                          ^^^^^^^^^^^^^ not found in this scope

Check failure on line 89 in grovedb/src/debugger.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

cannot find value `grove_version` in this scope

error[E0425]: cannot find value `grove_version` in this scope
  --> grovedb/src/debugger.rs:89:76
   |
89 |         .open_non_transactional_merk_at_path(path.as_slice().into(), None, grove_version)
   |                                                                            ^^^^^^^^^^^^^ not found in this scope

Check warning on line 49 in merk/src/estimated_costs/average_case_costs.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

duplicated attribute

warning: duplicated attribute
  --> merk/src/estimated_costs/average_case_costs.rs:49:7
   |
49 | #[cfg(feature = "full")]
   |       ^^^^^^^^^^^^^^^^
   |
note: first defined here
  --> merk/src/estimated_costs/average_case_costs.rs:48:7
   |
48 | #[cfg(feature = "full")]
   |       ^^^^^^^^^^^^^^^^
help: remove this attribute
  --> merk/src/estimated_costs/average_case_costs.rs:49:7
   |
49 | #[cfg(feature = "full")]
   |       ^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicated_attributes
   = note: `#[warn(clippy::duplicated_attributes)]` on by default

Check warning on line 807 in merk/src/tree/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
   --> merk/src/tree/mod.rs:784:5
    |
784 | /     pub fn put_value_with_reference_value_hash_and_value_cost(
785 | |         mut self,
786 | |         value: Vec<u8>,
787 | |         value_hash: CryptoHash,
...   |
806 | |         >,
807 | |     ) -> CostResult<Self, Error> {
    | |________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 349 in merk/src/tree/walk/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
   --> merk/src/tree/walk/mod.rs:326:5
    |
326 | /     pub fn put_value_with_reference_value_hash_and_value_cost(
327 | |         mut self,
328 | |         value: Vec<u8>,
329 | |         value_hash: CryptoHash,
...   |
348 | |         >,
349 | |     ) -> CostResult<Self, Error> {
    | |________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 723 in merk/src/tree/ops.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (10/7)

warning: this function has too many arguments (10/7)
   --> merk/src/tree/ops.rs:712:5
    |
712 | /     fn recurse<K: AsRef<[u8]>, C, V, U, R>(
713 | |         self,
714 | |         batch: &MerkBatch<K>,
715 | |         mid: usize,
...   |
722 | |         grove_version: &GroveVersion,
723 | |     ) -> CostResult<(Option<Self>, KeyUpdates), Error>
    | |______________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 157 in merk/src/tree/ops.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
   --> merk/src/tree/ops.rs:148:5
    |
148 | /     pub fn apply_to<K: AsRef<[u8]>, C, V, U, R>(
149 | |         maybe_tree: Option<Self>,
150 | |         batch: &MerkBatch<K>,
151 | |         source: S,
...   |
156 | |         grove_version: &GroveVersion,
157 | |     ) -> CostContext<Result<(Option<TreeNode>, KeyUpdates), Error>>
    | |___________________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 386 in merk/src/proofs/query/merge.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient

warning: assigning the result of `Clone::clone()` may be inefficient
   --> merk/src/proofs/query/merge.rs:385:17
    |
385 | /                 self.default_subquery_branch.subquery =
386 | |                     other_default_subquery_branch.subquery.clone();
    | |__________________________________________________________________^ help: use `clone_from()`: `self.default_subquery_branch.subquery.clone_from(&other_default_subquery_branch.subquery)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check warning on line 337 in merk/src/proofs/query/merge.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient

warning: assigning the result of `Clone::clone()` may be inefficient
   --> merk/src/proofs/query/merge.rs:336:25
    |
336 | /                         self.default_subquery_branch.subquery =
337 | |                             other_default_subquery_branch.subquery.clone();
    | |__________________________________________________________________________^ help: use `clone_from()`: `self.default_subquery_branch.subquery.clone_from(&other_default_subquery_branch.subquery)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check warning on line 253 in merk/src/proofs/query/merge.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient

warning: assigning the result of `Clone::clone()` may be inefficient
   --> merk/src/proofs/query/merge.rs:253:13
    |
253 |             self.default_subquery_branch.subquery = other_default_branch_subquery.clone();
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.default_subquery_branch.subquery.clone_from(&other_default_branch_subquery)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
    = note: `#[warn(clippy::assigning_clones)]` on by default

Check warning on line 5 in merk/src/proofs/chunk.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

module has the same name as its containing module

warning: module has the same name as its containing module
 --> merk/src/proofs/chunk.rs:5:1
  |
5 | pub mod chunk;
  | ^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
  = note: `#[warn(clippy::module_inception)]` on by default

Check warning on line 665 in merk/src/merk/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
   --> merk/src/merk/mod.rs:656:5
    |
656 | /     fn verify_link(
657 | |         &self,
658 | |         link: &Link,
659 | |         parent_key: &[u8],
...   |
664 | |         grove_version: &GroveVersion,
665 | |     ) {
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 596 in merk/src/merk/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
   --> merk/src/merk/mod.rs:596:10
    |
596 |     ) -> (BTreeMap<Vec<u8>, CryptoHash>, BTreeMap<Vec<u8>, Vec<u8>>) {
    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

Check warning on line 320 in merk/src/merk/apply.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (9/7)

warning: this function has too many arguments (9/7)
   --> merk/src/merk/apply.rs:310:5
    |
310 | /     pub fn apply_unchecked<KB, KA, C, V, U, R>(
311 | |         &mut self,
312 | |         batch: &MerkBatch<KB>,
313 | |         aux: &AuxMerkBatch<KA>,
...   |
319 | |         grove_version: &GroveVersion,
320 | |     ) -> CostResult<(), Error>
    | |______________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 227 in merk/src/merk/apply.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (9/7)

warning: this function has too many arguments (9/7)
   --> merk/src/merk/apply.rs:201:5
    |
201 | /     pub fn apply_with_costs_just_in_time_value_update<KB, KA>(
202 | |         &mut self,
203 | |         batch: &MerkBatch<KB>,
204 | |         aux: &AuxMerkBatch<KA>,
...   |
226 | |         grove_version: &GroveVersion,
227 | |     ) -> CostResult<(), Error>
    | |______________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 393 in merk/src/merk/chunks.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
   --> merk/src/merk/chunks.rs:393:10
    |
393 |     ) -> Option<Result<(Vec<Op>, Option<Vec<u8>>), Error>> {
    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

Check warning on line 363 in merk/src/merk/chunks.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
   --> merk/src/merk/chunks.rs:363:10
    |
363 |     ) -> Option<Result<(Vec<Op>, Option<Vec<u8>>), Error>> {
    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
    = note: `#[warn(clippy::type_complexity)]` on by default

Check warning on line 412 in merk/src/merk/restore.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `attempt_state_recovery` is never used

warning: method `attempt_state_recovery` is never used
   --> merk/src/merk/restore.rs:412:8
    |
67  | impl<'db, S: StorageContext<'db>> Restorer<S> {
    | --------------------------------------------- method in this implementation
...
412 |     fn attempt_state_recovery(&mut self, grove_version: &GroveVersion) -> Result<(), Error> {
    |        ^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

Check warning on line 3 in merk/src/tree/fuzz_tests.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

'test' may be misspelled as 'tests'

warning: 'test' may be misspelled as 'tests'
 --> merk/src/tree/fuzz_tests.rs:3:8
  |
3 | #![cfg(tests)]
  |        ^^^^^ help: did you mean: `test`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#maybe_misused_cfg
  = note: `#[warn(clippy::maybe_misused_cfg)]` on by default

Check warning on line 6 in grovedb/build.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `ExitStatus`

warning: unused import: `ExitStatus`
 --> grovedb/build.rs:6:28
  |
6 |         process::{Command, ExitStatus, Output},
  |                            ^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default