Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add invite funding key derivation path #140

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

HashEngineering
Copy link
Collaborator

This PR will add invite funding key derivation paths to DIP13.

@HashEngineering HashEngineering requested a review from thephez August 2, 2023 22:39
@HashEngineering HashEngineering self-assigned this Aug 2, 2023
dip-0013.md Outdated Show resolved Hide resolved
dip-0013.md Outdated Show resolved Hide resolved
dip-0013.md Outdated Show resolved Hide resolved
@thephez
Copy link
Collaborator

thephez commented Aug 3, 2023

This should also update the DIP-9 table: https://github.com/dashpay/dips/blob/master/dip-0009/assignments.md

@HashEngineering
Copy link
Collaborator Author

@thephez I have made the requested changes.

dip-0009/assignments.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the table of contents to include the new section? I just noticed it wasn't included there.

@HashEngineering
Copy link
Collaborator Author

@thephez I finally updated the PR based on your latest comments.

dip-0013.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor ones 🙂

dip-0013.md Outdated Show resolved Hide resolved
dip-0013.md Outdated Show resolved Hide resolved
dip-0013.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants