Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improved Docker documentation #5543

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

PanderMusubi
Copy link

Issue being fixed or feature implemented

Make Dash on Docker Hub easier to find, a search on dash there does not provide the result.

What was done?

Improved Docker documentation in contrib/containers/README.md

How Has This Been Tested?

n/a

Breaking Changes

n/a

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@PanderMusubi PanderMusubi changed the title improved Docker documentation docs: improved Docker documentation Aug 23, 2023
@UdjinM6 UdjinM6 changed the base branch from master to develop August 23, 2023 13:07
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, utACK

(note: we do not merge into master, changed it to develop and rebased)

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PanderMusubi
Copy link
Author

@thephez can you more this rather trivial change forward? Thanks.

Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 5e04b9f into dashpay:develop Sep 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants