Skip to content
This repository has been archived by the owner on Oct 19, 2022. It is now read-only.

fix: correctly detect apple darwin architectures #21

Closed
wants to merge 1 commit into from
Closed

fix: correctly detect apple darwin architectures #21

wants to merge 1 commit into from

Conversation

mayoreee
Copy link

Fixed the method used in the build script for detecting architecture type on Apple Darwin.

Issue being fixed or feature implemented

This fixes issue #19

The current build script relies on the Node.js method os.arch() for detecting architecture type. However, the method is unreliable as it incorrectly detects the Apple Silicon architecture.

Also, this is a known issue with os.arch() which has been reported severally, including here

What was done?

Changed the architecture detection method from Node.js's os.arch() to Unix's uname.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

@mayoreee mayoreee closed this by deleting the head repository Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants