This repository has been archived by the owner on Oct 19, 2022. It is now read-only.
fix: correctly detect apple darwin architectures #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the method used in the build script for detecting architecture type on Apple Darwin.
Issue being fixed or feature implemented
This fixes issue #19
The current build script relies on the
Node.js
methodos.arch()
for detecting architecture type. However, the method is unreliable as it incorrectly detects the Apple Silicon architecture.Also, this is a known issue with
os.arch()
which has been reported severally, including hereWhat was done?
Changed the architecture detection method from
Node.js
'sos.arch()
toUnix
'suname
.Checklist: