Skip to content
This repository has been archived by the owner on Oct 19, 2022. It is now read-only.

Mac build script incorrectly detects Apple Silicon's architecture #19

Open
mayoreee opened this issue Mar 10, 2022 · 0 comments
Open

Mac build script incorrectly detects Apple Silicon's architecture #19

mayoreee opened this issue Mar 10, 2022 · 0 comments

Comments

@mayoreee
Copy link

The Apple Silicon's architecture is incorrectly detected in the build_mac.sh script. The script detects and builds for the architecture as x64 instead of arm64.

Expected Behavior

Correctly detect the Apple Silicon architecture as arm64.

Current Behavior

The current build script uses the os.arch()method for architecture detection. However, this method isn't reliable in recognizing the Apple Silicon architecture.
It should generate prebuilds for arm64 on an Apple Silicon machine, but instead, it generates prebuilds for x64.

Steps to Reproduce (for bugs)

npm run build:mac

Your Environment

  • Apple Silicon (M1 mac)
  • Platform-host-triplet: arm64-apple-darwin21.2.0
  • macOS 12.1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant