You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
I like the module and I might be mistaken, but I think there is an issue with using the package for Angular 1.3.18 and possibly 1.3.x in general. Using the directive produces but an empty div. If I understand it correctly, this is because of changes to compile, where the transclude function argument used in the code has been deprecated. i.e., the offending lines are likely:
var e = compile(templateCache.get('ng-prettyjson/ng-prettyjson-panel.tmpl.html'))(scope, function(clonedElement, scope) {
scope.tmplElt = clonedElement;
});
The text was updated successfully, but these errors were encountered:
I need to check but if someone can put a PR relative to your problem, it is fine too, quite to busy right now but I will take a look asap. Thank you for providing such details.
Thanks for the quick response - I do not mind making a PR if it can wait a day or two. I wasn't sure whether you were still maintaining the project so I simply made a hotfix for myself, but this is not ideal. I am a bit worried about ensuring that my changes are backwards compatible though. What Angular versions are you trying to support?
Hi,
I like the module and I might be mistaken, but I think there is an issue with using the package for Angular 1.3.18 and possibly 1.3.x in general. Using the directive produces but an empty div. If I understand it correctly, this is because of changes to compile, where the transclude function argument used in the code has been deprecated. i.e., the offending lines are likely:
The text was updated successfully, but these errors were encountered: