Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile call signature deprecated #21

Open
cwenner opened this issue Sep 21, 2015 · 2 comments
Open

Compile call signature deprecated #21

cwenner opened this issue Sep 21, 2015 · 2 comments

Comments

@cwenner
Copy link

cwenner commented Sep 21, 2015

Hi,
I like the module and I might be mistaken, but I think there is an issue with using the package for Angular 1.3.18 and possibly 1.3.x in general. Using the directive produces but an empty div. If I understand it correctly, this is because of changes to compile, where the transclude function argument used in the code has been deprecated. i.e., the offending lines are likely:

var e = compile(templateCache.get('ng-prettyjson/ng-prettyjson-panel.tmpl.html'))(scope, function(clonedElement, scope) {          
        scope.tmplElt = clonedElement;        
      });
@darul75
Copy link
Owner

darul75 commented Sep 21, 2015

Hi,

I need to check but if someone can put a PR relative to your problem, it is fine too, quite to busy right now but I will take a look asap. Thank you for providing such details.

@cwenner
Copy link
Author

cwenner commented Sep 21, 2015

Thanks for the quick response - I do not mind making a PR if it can wait a day or two. I wasn't sure whether you were still maintaining the project so I simply made a hotfix for myself, but this is not ideal. I am a bit worried about ensuring that my changes are backwards compatible though. What Angular versions are you trying to support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants