Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM Service incorrectly wraps compileExpression error responses from external clients #59603

Open
bkonyi opened this issue Nov 25, 2024 · 0 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team vm-service The VM Service Protocol, both the specification and its implementation

Comments

@bkonyi
Copy link
Contributor

bkonyi commented Nov 25, 2024

When an external client providing a compileExpression service returns an error in response to a request, it should return an RPC error along the lines of {'error': { 'code': 113, 'message': 'Expression compilation error', 'details': '$cfeErrorOutput'}}. However, the VM Service (DDS does not have this problem) will return as the response to the expression evaluation request: {'error': { 'code': 113, 'message': 'Expression compilation error', 'details': '{'error': { 'code': 113, 'message': 'Expression compilation error', 'details': '$cfeErrorOutput'}}'}}.

The VM service should just directly return the expression compilation error from the external expression compilation service instead of wrapping its response.

@bkonyi bkonyi added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team vm-service The VM Service Protocol, both the specification and its implementation labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team vm-service The VM Service Protocol, both the specification and its implementation
Projects
None yet
Development

No branches or pull requests

2 participants