-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destroy via proxy is not working #212
Comments
Btw, none of methods working when called via proxy - you can test it at http://darsa.in/sly/ too. Eg:
Do nothing. |
Update: made few test and found that destroy via proxy working only if slider was initialized via proxy:
|
Reason why this happening is that reference to Sly instance stored in data attribute only when Sly created via proxy. Pull request: #213 |
Yeah, that was kinda by design, but I guess it makes sense while Sly still supports jQuery. I'm gonna implement your fix. And sorry for the delay 😐. |
Should be fixed now. |
Hooray, thanks! 😸 |
I've noticed that destroying slider via proxy method is not working:
Only direct destroy call works. You can try it yourself at Sly promo page:
Navigate to http://darsa.in/sly/ , open JS console and execute this code:
Nothing was destroyed.
The text was updated successfully, but these errors were encountered: