Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float operators are not yet supported #3303

Closed
pbiggar opened this issue Nov 29, 2021 · 1 comment
Closed

Float operators are not yet supported #3303

pbiggar opened this issue Nov 29, 2021 · 1 comment

Comments

@pbiggar
Copy link
Member

pbiggar commented Nov 29, 2021

Dark's operators (+, -, *, etc) work on integers. In Dark v1, we use Float::+ instead, which doesn't suck but isn't great

Non-solution: We speculated that we could use the editor to simply hide the Float:: part. However, that doesn't allow polymorphism, you can't have a library that takes numbers of any kind and (for example) sums them.

Solution: use traits to support reuse of common operators for different types

@pbiggar pbiggar added the v2 label Nov 29, 2021
@pbiggar pbiggar changed the title operators Float operators are not yet supported Nov 29, 2021
@pbiggar pbiggar removed the v-next label Mar 10, 2023
@StachuDotNet
Copy link
Member

folded into #5243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants