Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package manager should use owner ID #2929

Closed
pbiggar opened this issue Feb 3, 2021 · 1 comment
Closed

Package manager should use owner ID #2929

pbiggar opened this issue Feb 3, 2021 · 1 comment

Comments

@pbiggar
Copy link
Member

pbiggar commented Feb 3, 2021

Dark programs store calls to package manager functions using strings to represent the owner. But, if the owner changes their username, that will break. Worse, if the owner changes their username, and a new user takes the old username, there could be a security incident.

Instead, stored programs should call package manager functions using the owner's UUID. (Similarly, functions should be stored in programs as TLIDs, not function names, to make it easier to change the names).

@StachuDotNet
Copy link
Member

redundant with another issue, but folded into #5243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants