Introduce interface for topic event subscriber #661
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I introduced the
TopicEventSubscriber
interface and added anAddTopicEventSubscriber
method to theServer
interface.TopicEventSubscriber
will allow more complex subscribers to be registered that are using structs so that dependencies likesql.DB
objects or other parameters can be provided to subscribers and used to process incoming events.I modified
TopicRegistrar
to register and storeTopicEventSubscriber
instead ofTopicEventHandler
in theTopicRegistration struct. I created an adapter for
TopicEventHandlerso that it implements the new
TopicEventSubscriber` interface and can continue to be used without modification.TopicEventSubscriber
type instead of rewriting theTopicEventHandler
type to not break existing code. I used the pattern thatnet/http
uses forHandler
andHandlerFunc
.TopicRegistration
and makingTopicEventHandler
implementTopicEventSubscriber
, I didn't think that any additional tests were necessary.Issue reference
Please reference the issue this PR will close: #660
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: