Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect issue after new space creation #2561

Open
elatif2020 opened this issue Feb 2, 2024 · 3 comments
Open

Redirect issue after new space creation #2561

elatif2020 opened this issue Feb 2, 2024 · 3 comments

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Feb 2, 2024

Somehow after clicking "Create Space" button a new space is created but the form remains open. We should fix it and redirect the user to the newly created space.

@budnik9
Copy link
Contributor

budnik9 commented Feb 2, 2024

@elatif2020 @danielr18
Have we recently updated the response data structure of the project creation endpoint (POST /proposals/action)?
UI waits for new project data to be placed in the circleProjectSubcommon property (like in the image below)

image

But currently on the dev environment, the backend returns data at the top level of the repsonse object:

image

So I can't figure out if this is a BE or FE issue.

@elatif2020
Copy link
Collaborator Author

@elatif2020 @danielr18
Have we recently updated the response data structure of the project creation endpoint (POST /proposals/action)?
UI waits for new project data to be placed in the circleProjectSubcommon property (like in the image below)

image

But currently on the dev environment, the backend returns data at the top level of the repsonse object:

image

So I can't figure out if this is a BE or FE issue.

I guess we are changing this with the removal of project circle. So probably we should change accordingly in the FE. correct ? @danielr18

@budnik9
Copy link
Contributor

budnik9 commented Feb 3, 2024

@elatif2020 I created the draft PR with the fix - #2562.
If the issue should be fixed on the FE side, please review it and merge.

budnik9 added a commit that referenced this issue Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants