Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus switches to another stream after deleting a message #2412

Open
elatif2020 opened this issue Dec 20, 2023 · 9 comments
Open

Focus switches to another stream after deleting a message #2412

elatif2020 opened this issue Dec 20, 2023 · 9 comments
Labels
bug Something isn't working Priority - B

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Dec 20, 2023

See the comment here: #2398 (comment)
We should make sure to keep the focus on the current item.

@elatif2020 elatif2020 added bug Something isn't working Priority - A labels Dec 20, 2023
@budnik9
Copy link
Contributor

budnik9 commented Dec 21, 2023

@elatif2020 I faced the issue of infinite inbox update in dev. So now I'm working on this issue, because it blocks this ticket. So it will be great if you create a ticket for the issue I mentioned once you are available!

@budnik9
Copy link
Contributor

budnik9 commented Dec 22, 2023

@elatif2020 I fixed the issue, I mentioned above. I will push the fix later as a part of this ticket. Still working on the issue of focus switching. For some reason, sometimes our inbox items subscription indicate that the item where the message was deleted has been removed. So I try to find out why it happens. Also I faces one more issue. Occasionally messages that were just deleted show up in chat after a while. Please check it and let me know if I need to fix this issue as a part pf this ticket too.

@elatif2020
Copy link
Collaborator Author

@elatif2020 I faced the issue of infinite inbox update in dev. So now I'm working on this issue, because it blocks this ticket. So it will be great if you create a ticket for the issue I mentioned once you are available!

@budnik9 thanks 🙏
Here: #2416

@elatif2020
Copy link
Collaborator Author

@elatif2020 I fixed the issue, I mentioned above. I will push the fix later as a part of this ticket. Still working on the issue of focus switching. For some reason, sometimes our inbox items subscription indicate that the item where the message was deleted has been removed. So I try to find out why it happens. Also I faces one more issue. Occasionally messages that were just deleted show up in chat after a while. Please check it and let me know if I need to fix this issue as a part pf this ticket too.

@budnik9
Thanks for bringing this to attention.
I created a ticket for the other issue: #2417
and I guess we should take care of it in this case 🙏

@elatif2020
Copy link
Collaborator Author

@budnik9 could you please write your conclusions regarding this issue?
Not sure we should take care of it now if it's a rare case

@budnik9
Copy link
Contributor

budnik9 commented Dec 28, 2023

@elatif2020 Nothing has changed since I left my last comment, as I've been working on other bugs that are reproduced much more frequently. If this is a rare case, we can postpone the fix for now

@elatif2020
Copy link
Collaborator Author

@elatif2020 Nothing has changed since I left my last comment, as I've been working on other bugs that are reproduced much more frequently. If this is a rare case, we can postpone the fix for now

@budnik9 Okay, to explain myself better, I was referring to what you told me about when this issue can be reproduced. Maybe you can write it here?

@budnik9
Copy link
Contributor

budnik9 commented Dec 28, 2023

@elatif2020 Sure
The issue is usually reproduced when the delete endpoint has not been called for some time, and it is kind of in cold state.
@danielr18 Are any changes made to the inbox collection when processing this request DELETE /discussions/message?

@budnik9
Copy link
Contributor

budnik9 commented Jan 8, 2024

@elatif2020 Sure The issue is usually reproduced when the delete endpoint has not been called for some time, and it is kind of in cold state. @danielr18 Are any changes made to the inbox collection when processing this request DELETE /discussions/message?

@danielr18 Please take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority - B
Projects
None yet
Development

No branches or pull requests

2 participants