Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon errors and huge number of files #403

Open
grotesque opened this issue Jan 4, 2025 · 10 comments
Open

favicon errors and huge number of files #403

grotesque opened this issue Jan 4, 2025 · 10 comments

Comments

@grotesque
Copy link

gomita's scrapbook plus, scrapbook-x had the issue of large number of files on filesystem which can slow it (the filesystem) down giving system wide symptoms.
webscrapbook has resolved that problem with htz extension for storing webpage. Thank you Danny.

but the favicon design is causing similar problems of large number of files (to a smaller extent)

Other problems:

  • lots of unnessary warnings like "icon 'xxx' is an absolute URL" while running the checker
  • lots of unncessary errors like missing icon file 'xxx/favicon.ico'
  • they occupy about 30% of the total number of files in my webscrapbook "database"
  • they give no value to me

{12377EDF-7A0E-4471-BE40-FFCD82578297}

Q1. Have I configured by webscrapbook wrong because I don't see any icons usually in sidebar. Sometimes they're seen.
Q2. Can a setting be made to globally disable icons so that they are not even created.

@grotesque grotesque changed the title favion errors and huge number of files favicon errors and huge number of files Jan 4, 2025
@grotesque
Copy link
Author

update:
favicons are not working for me in firefox webscrapbook (latest version)
They're working on chrome webscrapbook (latest version)

Chrome:
{A8701280-29A6-4C15-8016-99052302DCCE}

Any idea why?

@danny0838
Copy link
Owner

gomita's scrapbook plus, scrapbook-x had the issue of large number of files on filesystem which can slow it (the filesystem) down giving system wide symptoms. webscrapbook has resolved that problem with htz extension for storing webpage. Thank you Danny.

but the favicon design is causing similar problems of large number of files (to a smaller extent)

The only one way to really solve the issue is probably to convert scrapbooks to DBMS-based. Unfortunately this is a tremendous work and the difficulty and inconvenience of managing DBMS may overweight the benefit.

An easier solution would be to split your data into sub-scrapbooks.

Other problems:

* lots of unnessary warnings like "icon 'xxx' is an absolute URL" while running the checker

* lots of unncessary errors like missing icon file 'xxx/favicon.ico'

* they occupy about 30% of the total number of files in my webscrapbook "database"

* they give no value to me

Item icon with an absolute URL should be avoided because the icon is not really saved in your scrapbook and will be missing once the external website is down.

You can usually check the Automatically cache icons with absolute URL option to automatically fix the issue.

Missing icon file is of course an issue because the URL is wrong and the icon cannot be accessed. You should either correct the icon path or blank the icon path to use the default item icon instead.

{12377EDF-7A0E-4471-BE40-FFCD82578297}

Q1. Have I configured by webscrapbook wrong because I don't see any icons usually in sidebar. Sometimes they're seen.

Please check the item icon path and see if the file is missing. It may be due to network instability if it is an external absolute URL. It may be due to a server delay if it's local and there are too many icons to show, and can usually be solved by refreshing the page, or by switching to a more expert and performant local WSGI server.

Q2. Can a setting be made to globally disable icons so that they are not even created.

This seems to be a very large code work and I don't think it's good for UX. You can usually blank item icons using a script and remove cached icon files through the checker with Automatically remove unused favicon cache option checked.

@grotesque
Copy link
Author

grotesque commented Jan 4, 2025

Please check the item icon path and see if the file is missing.

The favicon files are there. And they're kind of working in chrome not in firefox.
Pls see my earlier message.

@danny0838
Copy link
Owner

Check if the image URLs are correct, and try reloading the page to see if it changes.

@grotesque
Copy link
Author

the image urls are like
.wsb/tree/favicon/b37ac89616b9e4c01a35991af59fe6b63e41a48e.ico
and they exists

funny thing is it works in chrome but not in firefox

@danny0838
Copy link
Owner

Have you tried reloading the page?

@grotesque
Copy link
Author

yes

@danny0838
Copy link
Owner

What is the result?

@grotesque
Copy link
Author

Same issue danny. Does anybody else using firefox face this issue too?

@danny0838
Copy link
Owner

danny0838 commented Jan 8, 2025

Are all missing icons the same when the web page is refreshed?

Can you see the image if you right click on a missing icon and open the image in another tab?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants