Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__cplusplus not set when DUI::std is empty/invalid #352

Open
firewave opened this issue May 6, 2024 · 2 comments
Open

__cplusplus not set when DUI::std is empty/invalid #352

firewave opened this issue May 6, 2024 · 2 comments
Assignees
@firewave

Comments

@firewave
Copy link
Collaborator

firewave commented May 6, 2024

The __cplusplus macro is not set when the provide DUI::std is either empty or invalid. This might lead to unexpected behavior.
@firewave
Copy link
Collaborator Author

firewave commented May 6, 2024

  • if the provided standard is invalid we should bail out
  • if no standard is being provided we should default to the latest

@firewave
Copy link
Collaborator Author

  • if the provided standard is invalid we should bail out

With #312 merged we do not bail out but provide an error via OutputList to indicate that the given standard is unknown.

firewave added a commit to firewave/simplecpp that referenced this issue May 23, 2024
@firewave
fixes danmar#352 - default to latest standard if none is provided
60ee8fe
@firewave firewave self-assigned this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@firewave firewave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@firewave