Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enableIsDirty breaks when used with ember-data-model-fragments #38

Open
wizbyt opened this issue Feb 19, 2018 · 1 comment
Open

enableIsDirty breaks when used with ember-data-model-fragments #38

wizbyt opened this issue Feb 19, 2018 · 1 comment

Comments

@wizbyt
Copy link

wizbyt commented Feb 19, 2018

Setting enableIsDirty whilst using ember-data-model-fragments and changing any belongsTo or hasMany relationship doesn't change any of the flags on a model.

Any changes to the relationships on a model leave the flags as false:

hasDirtyAttributes: false
hasDirtyRelations: false
isDirty: false

Removing the enableIsDirty configuration option makes the "hasDirtyAttributes" flag work again.

I'm not sure whether the problem is with ember-data-change-tracker or ember-data-model-fragments.

@danielspaniel
Copy link
Owner

sorry for late reply @wizbyt .. do you think you can write up a test in a PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants