PhantomNR #480
Merged
PhantomNR #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… radiation dominated setup
danieljprice
requested changes
Oct 26, 2023
src/main/readwrite_dumps_fortran.F90
Outdated
| @@ -364,6 +370,26 @@ subroutine write_fulldump_fortran(t,dumpfile,ntotal,iorder,sphNG) | |||
| if (gr) then | |||
| call write_array(1,pxyzu,pxyzu_label,maxvxyzu,npart,k,ipass,idump,nums,ierrs(8)) | |||
| call write_array(1,dens,'dens prim',npart,k,ipass,idump,nums,ierrs(8)) | |||
| #ifdef GR | |||
There was a problem hiding this comment.
please remove the #ifdef GR here and just use an if (gr) then
see #55
src/main/readwrite_dumps_fortran.F90
Outdated
| @@ -227,6 +230,9 @@ subroutine write_fulldump_fortran(t,dumpfile,ntotal,iorder,sphNG) | |||
| #ifdef PRDRAG | |||
| use lumin_nsdisc, only:beta | |||
| #endif | |||
| #ifdef GR | |||
There was a problem hiding this comment.
please remove the ifdef GR here, metric_tools is always compiled even with the non-relativistic code
src/main/readwrite_dumps_fortran.F90
Outdated
| @@ -218,6 +218,9 @@ subroutine write_fulldump_fortran(t,dumpfile,ntotal,iorder,sphNG) | |||
| rad,rad_label,radprop,radprop_label,do_radiation,maxirad,maxradprop,itemp,igasP,igamma,& | |||
| iorig,iX,iZ,imu,nucleation,nucleation_label,n_nucleation,tau,itau_alloc,tau_lucy,itauL_alloc,& | |||
| luminosity,eta_nimhd,eta_nimhd_label | |||
| #ifdef GR | |||
There was a problem hiding this comment.
please remove the ifdef here, it is not necessary, see #55
src/main/readwrite_dumps_fortran.F90
Outdated
| @@ -385,7 +411,7 @@ subroutine write_fulldump_fortran(t,dumpfile,ntotal,iorder,sphNG) | |||
| endif | |||
|
|
|||
| ! smoothing length written as real*4 to save disk space | |||
| call write_array(1,xyzh,xyzh_label,1,npart,k,ipass,idump,nums,ierrs(14),use_kind=4,index=4) | |||
| call write_array(1,xyzh,xyzh_label,1,npart,k,ipass,idump,nums,ierrs(14),use_kind=8,index=4) | |||
There was a problem hiding this comment.
please undo this if possible, or put an if (imet=imet_et) around it and revert to real*4 otherwise
src/main/step_leapfrog.F90
Outdated
| @@ -791,7 +794,7 @@ subroutine step_extern_gr(npart,ntypes,dtsph,dtextforce,xyzh,vxyzu,pxyzu,dens,me | |||
| ! | |||
| if (dtextforce < dtsph) then | |||
| dt = dtextforce | |||
| last_step = .false. | |||
| last_step = .true. ! Just to check if things are working | |||
There was a problem hiding this comment.
please undo this, it's dangerous
| return | ||
| endif | ||
|
|
||
|
|
| use mpidomain, only:i_belong | ||
| use stretchmap, only:set_density_profile | ||
| use utils_gr, only:perturb_metric, get_u0, get_sqrtg | ||
| !use cons2primsolver, only:primative2conservative |
src/setup/setup_flrw.f90
Outdated
| call write_inopt(perturb_direction, 'FLRWSolver::FLRW_perturb_direction','Pertubation direction',iunit) | ||
| call write_inopt(radiation_dominated, 'radiation_dominated','Radiation dominated universe (yes/no)',iunit) | ||
| call write_inopt(perturb_wavelength,'FLRWSolver::single_perturb_wavelength','Perturbation wavelength',iunit) | ||
| if (use_dustfrac) then |
There was a problem hiding this comment.
delete unused options to do with dust and MHD
src/main/initial.F90
Outdated
| call get_grforce_all(npart,xyzh,metrics,metricderivs,vxyzu,dens,fext,dtextforce) | ||
| !print*, "Before get_tmunu_all" |
There was a problem hiding this comment.
can remove debugging statements
| SETUPFILE= setup_flrw.f90 | ||
| PERIODIC=yes | ||
| endif | ||
| ifeq ($(SETUP), flrwpspec) |
There was a problem hiding this comment.
please add a comment after the #ifeq giving a description of the setup (this is used in the docs)
danieljprice
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
New physics
Description:
Adds the code detailed in Magnall et al. 2023
Testing:
See Magnall et al. 2023
Did you run the bots? no
Did you update relevant documentation in the docs directory? yes