Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal speed used in tcour should include radiation pressure #474

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

themikelau
Copy link
Collaborator

Add contribution of radiation pressure to signal speed when using radiation (e.g., Eq 10 in https://arxiv.org/abs/1102.1216). We should have cs = (5/3Pgas/rho + 4/3Prad/rho)^1/2. Otherwise, tcour may be underestimated.

@danieljprice
Copy link
Owner

this is a good idea, however we should test before merging as it would also increase the shock viscosity. Best problem for this would be the radiation shock tube (radshock) although we'd need to do it in a regime where radiation pressure is significant to see what difference this makes to the shock capturing (and indeed the stability)

@danieljprice danieljprice merged commit 420f5a6 into master Oct 23, 2023
177 checks passed
@danieljprice danieljprice deleted the tcourant branch October 23, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants