Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: body with ContentTypeFilter should update OpenAPI #667

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

danielgtaylor
Copy link
Owner

This PR takes into account when a response body has a ContentTypeFilter implemented and uses application/json as its input to determine the output content type to be used in the generated OpenAPI document.

Fixes #559.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.77%. Comparing base (0fefc6f) to head (e3e4560).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   92.76%   92.77%           
=======================================
  Files          22       22           
  Lines        4910     4915    +5     
=======================================
+ Hits         4555     4560    +5     
  Misses        308      308           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielgtaylor danielgtaylor merged commit 3cde41a into main Dec 5, 2024
7 checks passed
@danielgtaylor danielgtaylor deleted the content-type-filter-openapi branch December 5, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Implementation of ContentTypeFilter doesn't affect OAS generation.
1 participant