Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: operation callbacks shape #665

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix: operation callbacks shape #665

merged 1 commit into from
Dec 4, 2024

Conversation

danielgtaylor
Copy link
Owner

This fixes a mistake with how the Operation.Callbacks get defined. It should be a map of name to map of URL expression to path item object, as described in the linked issue. This is only used by external tools, so no tests within Huma for now.

Fixes #653.

@danielgtaylor danielgtaylor requested a review from Copilot December 4, 2024 00:30

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Repository owner deleted a comment from coderabbitai bot Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (4f98ee6) to head (375568c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files          22       22           
  Lines        4905     4905           
=======================================
  Hits         4550     4550           
  Misses        308      308           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielgtaylor danielgtaylor merged commit 4b4221f into main Dec 4, 2024
7 checks passed
@danielgtaylor danielgtaylor deleted the fix-callbacks branch December 4, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

huma.Operation.Callbacks usage is unclear
1 participant