-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(schema): schema example not work in Parameter #532
Conversation
WalkthroughThe update enhances the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
=======================================
Coverage 92.68% 92.69%
=======================================
Files 22 22
Lines 3844 3847 +3
=======================================
+ Hits 3563 3566 +3
Misses 236 236
Partials 45 45 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- huma.go (1 hunks)
Additional context used
GitHub Check: codecov/patch
huma.go
[warning] 171-171: huma.go#L171
Added line #L171 was not covered by tests
Additional comments not posted (1)
huma.go (1)
170-172
: Enhancement: Assign default example from schema examples.The new logic improves the function by assigning a default example from
pfi.Schema.Examples
if no specific example is provided. This enhances the flexibility and usability of the function.Tools
GitHub Check: codecov/patch
[warning] 171-171: huma.go#L171
Added line #L171 was not covered by tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fourcels this looks great, but can you add a test to cover this use case? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- huma_test.go (1 hunks)
Additional comments not posted (2)
huma_test.go (2)
2137-2145
: LGTM!The type
SchemaWithExample
and its methodSchema
are correctly defined. The schema specifies the type ashuma.TypeInteger
and includes an example value of1
.
2147-2161
: LGTM!The test function
TestSchemaWithExample
correctly validates the behavior of theSchemaWithExample
type within an API context. The example value for the query parameter is correctly asserted to be1
.
Summary by CodeRabbit