feat!: drop chi v4 adapter #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V4 has been deprecated for 7 months since da7ce9468546b9c352b0c7eac3580961543d0d96
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
=======================================
Coverage 92.74% 92.74%
=======================================
Files 21 21
Lines 3556 3556
=======================================
Hits 3298 3298
Misses 220 220
Partials 38 38 ☔ View full report in Codecov by Sentry. |
danielgtaylor
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V4 has been deprecated for 7 months since da7ce946
We could also split it into a different package, but IMHO the maintenance overhead doesn't seem worth it for a deprecated version. People can still maintain separate adapter, since there are no huma-internal dependencies.
Fixes #423