Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more robust nil check for link transformer #418

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

danielgtaylor
Copy link
Owner

This uses reflection to check for nil which is more robust and can prevent a panic/500 error from happening if the operation returns successful with a nil body.

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.71%. Comparing base (babafa8) to head (7f74b7d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
+ Coverage   92.65%   92.71%   +0.05%     
==========================================
  Files          21       21              
  Lines        3539     3540       +1     
==========================================
+ Hits         3279     3282       +3     
+ Misses        221      220       -1     
+ Partials       39       38       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielgtaylor danielgtaylor merged commit da22a6c into main Apr 28, 2024
5 checks passed
@danielgtaylor danielgtaylor deleted the fix-transform-nil branch April 28, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant