Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action button's href in passwordReset/passwordChange not rendering #261

Open
vesamet opened this issue Jan 12, 2020 · 1 comment
Open

Action button's href in passwordReset/passwordChange not rendering #261

vesamet opened this issue Jan 12, 2020 · 1 comment

Comments

@vesamet
Copy link

vesamet commented Jan 12, 2020

Hi there!

Issue:
Previous versions of Pug/Jade supported an interpolation syntax such as:
a(href="/#{url}")
, but is not more supported in attributes.
Therefore, the link is not rendered properly in emai's action button.

Solution:
Changing following line in src/api/services/emails/passwordReset/html.pug
a.f-fallback.button.button--green(href=passwordResetUrl target='_blank' style='...')
to
a.f-fallback.button.button--green(href=passwordResetUrl target='_blank' style='...')
resolve the problem.

I may suggest a pullrequest if you wish.

Anyhow, have a good day :)

@danielfsousa
Copy link
Owner

Feel free to open a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants