Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick the right pubkey on zaps with multiple p-tags #8

Open
jb55 opened this issue Sep 26, 2024 · 1 comment
Open

Pick the right pubkey on zaps with multiple p-tags #8

jb55 opened this issue Sep 26, 2024 · 1 comment
Assignees
Milestone

Comments

@jb55
Copy link
Contributor

jb55 commented Sep 26, 2024

It looks like some zappers are incorrectly adding more than one p-tag to a zap. They should be using P tags instead.

One thing we can do to detect the correct p-tag is to look at the pubkey on the zap request, and use the p-tag that is not the zap request pubkey.

@alltheseas
Copy link

alltheseas commented Oct 14, 2024

if there is p-tag and e-tag : note zap
of only p-tag : profile zap

some zappers attaching p-tag incorrectly (zap came from this person)
has to find correct p tag - only way to do this is look at zap requests - exclude this p tag, and then send notification

upper case P tag : "this is person who sent the zap"

proposed solution:

zap request is in the zap note. when fetch zap note, put within invoice. zapper puts zap in tag. signed note from person who initiated zap. zap note.

Daniel: is zap spec defining two events?
W: zap events come packaged in note.

@jb55 to tackle

@alltheseas alltheseas added this to the 1.11 - lists milestone Oct 14, 2024
@jb55 jb55 moved this from Backlog to Planned in Damus Roadmap 🛣️ Oct 15, 2024
@danieldaquino danieldaquino assigned danieldaquino and unassigned jb55 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Planned
Development

No branches or pull requests

3 participants