Refactor response handling in payment re-query

damms005 · Oct 25, 2024 · 5f4996f · 5f4996f
1 parent 75afcad
commit 5f4996f
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/src/Services/PaymentHandlers/Paystack.php b/src/Services/PaymentHandlers/Paystack.php
@@ -96,7 +96,7 @@ public function reQuery(Payment $existingPayment): ?ReQuery
         try {
             $verificationResponse = $this->verifyPaystackTransaction($existingPayment->processor_transaction_reference);
         } catch (\Throwable $th) {
-            return new ReQuery($existingPayment, $th->getMessage());
+            return new ReQuery($existingPayment, ['error' => $th->getMessage()]);
         }
 
         // status should be true if there was a successful call
@@ -124,7 +124,7 @@ public function reQuery(Payment $existingPayment): ?ReQuery
 
         return new ReQuery(
             payment: $payment,
-            responseDescription: 'Response from gateway server: ' . json_encode((array)$verificationResponse),
+            responseDetails: (array)$verificationResponse,
         );
     }
 

diff --git a/src/Services/PaymentHandlers/Remita.php b/src/Services/PaymentHandlers/Remita.php
@@ -158,7 +158,7 @@ public function reQuery(Payment $existingPayment): ?ReQuery
 
         return new ReQuery(
             payment: $payment,
-            responseDescription: 'Response from gateway server: ' . json_encode((array)$rrrQueryResponse),
+            responseDetails: (array)$rrrQueryResponse,
         );
     }
 

diff --git a/src/ValueObjects/ReQuery.php b/src/ValueObjects/ReQuery.php
@@ -8,6 +8,10 @@ class ReQuery
 {
     public function __construct(
         public Payment $payment,
-        public string $responseDescription,
+
+        /**
+         * An array of arbitrary shape based on the specific payment handler.
+         */
+        public array $responseDetails,
     ) {}
 }
diff --git a/tests/PaymentRequeryTest.php b/tests/PaymentRequeryTest.php
@@ -33,7 +33,7 @@
         $mock->expects('reQuery')->andReturn(
             new ReQuery(
                 payment: new Payment(),
-                responseDescription: 'Successful',
+                responseDetails: ['status' => 'Successful'],
             ),
         );
 
@@ -52,7 +52,7 @@
         $mock->expects('reQuery')->andReturn(
             new ReQuery(
                 payment: new Payment(['is_success' => true]),
-                responseDescription: 'Successful',
+                responseDetails: ['status' => 'Successful'],
             ),
         );
 
@@ -76,7 +76,7 @@
         $mock->expects('reQuery')->andReturn(
             new ReQuery(
                 payment: new Payment(['is_success' => false]),
-                responseDescription: 'Went South!',
+                responseDetails: ['status' => 'Went South!'],
             ),
         );