Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty attributes #336

Merged
merged 3 commits into from
Jun 27, 2020
Merged

Allow empty attributes #336

merged 3 commits into from
Jun 27, 2020

Conversation

bersace
Copy link
Member

@bersace bersace commented Jun 26, 2020

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2020

Codecov Report

Merging #336 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   99.63%   99.68%   +0.05%     
==========================================
  Files          12       12              
  Lines        1906     1914       +8     
==========================================
+ Hits         1899     1908       +9     
+ Misses          7        6       -1     
Impacted Files Coverage Δ
ldap2pg/manager.py 100.00% <100.00%> (ø)
ldap2pg/validators.py 100.00% <100.00%> (ø)
ldap2pg/utils.py 100.00% <0.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ced6800...018162b. Read the comment docs.

@bersace bersace marked this pull request as ready for review June 26, 2020 15:41
@bersace bersace merged commit 656af8f into dalibo:master Jun 27, 2020
@bersace bersace deleted the vide branch June 27, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for empty AD group in LDAP sync
2 participants