-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a flag to treat warnings as errors #338
Comments
Thanks @andersbogsnes In #337 , I change a warning to an error. I also changed behaviour on mispelled attribute to raise an error. This make ldap2pg less sloppy. This is a good reason to implement #286 . It's easy to check for warning if we count them. @andersbogsnes do you prefer to stop on first warning (i.e. make warning critical) or continue but fail in the end if there has been one or more warning ? |
If I'm running in strict mode, it's generally because I want to fail fast and get immediate feedback - that is also the behaviour of other tooling, including python: Sphinx: https://www.sphinx-doc.org/en/master/man/sphinx-build.html (See the -W flag) |
Great. So i suggest a |
As of ldap2pg v6, this would apply to the following warning:
Not for the following warning:
|
When running ldap2pg, it can be useful to be able to upgrade a warning to an error, so that we get a failure. This is a good way to quickly see if something could be wrong with my configuration, while allowing ldap2pg to adopt warnings for corner cases.
The text was updated successfully, but these errors were encountered: