Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subprocess fails on compojure #12

Open
atroche opened this issue Oct 12, 2014 · 7 comments
Open

Subprocess fails on compojure #12

atroche opened this issue Oct 12, 2014 · 7 comments

Comments

@atroche
Copy link

atroche commented Oct 12, 2014

Leiningen 2.4, OS X Yosemite, compojure is latest master.

› lein bikeshed   

Checking for lines longer than 80 characters.
Badly formatted files:
/Users/aroche/Code/clj/compojure/test/compojure/core_test.clj:174:          request        (mock/request :get "/ip/0%3A0%3A0%3A0%3A0%3A0%3A0%3A1%250") ]
/Users/aroche/Code/clj/compojure/test/compojure/response_test.clj:53:      (is (= (get-in response [:headers "Content-Length"]) (str (count body-str))))

Checking for lines with trailing whitespace.
No lines found.

Checking for files ending in blank lines.
No files found.

Checking for redefined var roots in source directories.
No with-redefs found.

Checking whether you keep up with your docstrings.
25/42 [59.52%] functions have docstrings.
Use -v to list functions without docstrings
Subprocess failed

cc @weavejester

@weavejester
Copy link

Unlike jonase/eastwood#88, this looks like a legitimate warning, not an exception.

@atroche
Copy link
Author

atroche commented Oct 12, 2014

The “subprocess failed” part?

@dakrone
Copy link
Owner

dakrone commented Oct 12, 2014

The "subprocess failed" part is because lein-bikeshed calls (System/exit -1) if the bikeshed check fails.

@xpe
Copy link

xpe commented Apr 8, 2015

I just fixed the problems identified by bikeshed. Now it reports this error. Strange.

Checking for arguments colliding with clojure.core functions.
Subprocess failed

@BenjaminVanRyseghem
Copy link
Collaborator

It sounds like it's because you have some arguments colliding with core function names.

But it's a bit weird that there is no other output than that

@dakrone
Copy link
Owner

dakrone commented Apr 8, 2015

Yeah, it should have output similar to:

Checking for arguments colliding with clojure.core functions.
#'clj-http.client/coerce-transit-form-params: 'type' is colliding with a core function
#'clj-http.client/content-type-value: 'type' is colliding with a core function
#'clj-http.client/parse-transit: 'type' is colliding with a core function
#'clj-http.client/coerce-json-body: 'keyword?' is colliding with a core function
#'clj-http.client/coerce-transit-body: 'type' is colliding with a core function
#'clj-http.client/transit-encode: 'type' is colliding with a core function
#'clj-http.core/set-client-param: 'key', 'val' are colliding with core functions
#'clj-http.headers/assoc-join: 'name' is colliding with a core function
Subprocess failed

I'll see if I can reproduce it on compojure, @xpe do you have a particular SHA that it reproduces with?

@theophilusx
Copy link

Was there any more info on this? I'm seeing same error, but no compojure (though library does use core.async). Rest of output shows nothing concerning (except low docstring %!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants