Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: app notifications needs to be exported to i18n #1291

Open
Ethanol48 opened this issue Aug 22, 2024 · 2 comments
Open

mobile: app notifications needs to be exported to i18n #1291

Ethanol48 opened this issue Aug 22, 2024 · 2 comments

Comments

@Ethanol48
Copy link
Contributor

Ethanol48 commented Aug 22, 2024

It seems that notifications were missed for the implementation of i18n.

I found a file that could be the responsible for these notifications.

https://github.com/daimo-eth/daimo/blob/master/apps/daimo-mobile/src/logic/externalAction.ts

@dcposch
Copy link
Member

dcposch commented Aug 22, 2024

Needs a bit more than export.

  • When we're rendering a UI (web or mobile), we can use the user's configured locale
  • When rendering a link preview, no locale > can be included in link based on the sender (link creator's) locale
  • When sending an app notification, comes from server > I think we'll have to store the recipient's last-known locale

@Ethanol48 Ethanol48 changed the title App notifications needs to be exported to i18n mobile: app notifications needs to be exported to i18n Aug 23, 2024
@Ethanol48
Copy link
Contributor Author

Ethanol48 commented Aug 23, 2024

We could add this field to the Account in storage

account storage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants