Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow (Inherited) Folder Restriction In Data Object/Document Tree #191

Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Dec 1, 2023

Q A
Branch? 4.x
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #190

@solverat
Copy link
Member

solverat commented Dec 18, 2024

Hey @blankse, if this is still relevant (this year was one hell of ride for us, so sorry for my very very late reponse):

Could you rebase this on 5.x (remove the o_ prefix)?

I also just checked your PR and there is this (quite big) issue, described in the ticket (#190):

"Check if children are valid candidates (based on allowed_objects for data objects, and page for documents)"

It's quite hard, to determinate if there are matching object within the folder, there could be thousand of objects in there. So I think there is more work to do.

However, I also noticed within your PR:

  • Documents:
    • It seems to work: Only documents of type page will be recognized, also the ui in backend (folder icon) applies correctly
  • Objects, if I'm applying groups to the object folder:
    • no icon appears (because of the missing check in TreeListener) on folder level
    • a restriction will be added to all its children, regardless of the configured classes which is not what we want (only apply them to the configured allowed_objects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants