bootstrap 5

[jjshoe]

Feature request: Support bootstrap 5

[daattali]

Realistically it'll probably be a very long time until that happens.
It took me over 100 hours of work to switch from BS3 to BS4, because I try to be very backwards compatible and not affect/changing any existing behaviours. Unless there is a problem with BS4, I'm not sure I'll find time for such a big task again in the near future. Perhaps if someone funds me for that project I'll make it a higher priority.

[daattali]

Is there anything specific in bootstrap 5 you were looking for?

[daattali]

Seeing as BS5 has already been around for almost 3 years, realistically I think I prefer to wait until BS6 comes out before considering making an upgrade.

[whoafridi]

@daattali don't think we get bs6 in real quick

[daattali]

That's ok, it can wait. If they'll say that bs6 won't be coming for a decade then I'll look at updating at some point, but if it's 2ish years, that's worth the wait. It's a BIG undertake to make the update, and make sure it doesn't break old websites.

[ReenigneArcher]

Waiting for v6 is kind of crazy, isn't it? That may never even happen if there aren't major breaking changes.

Personally, I think color-modes is a really nice feature for v5.3+. It allows to easily change from light to dark modes.

[daattali]

I don't think it's that crazy, most themes don't continuously refactor their code in order to keep up with their core libraries. For a single website to migrate from v4 to v5 is not a huge deal because you can see all the breaking changes and decide for youself if it's worth it, and when implementing the migration you can fix any issues one by one. For a general theme used by many people, that's not the case. Also keep in mind that I work on this for free, so it's not feasible for me to put in the dozens of hours on just doing a bootstrap migration every couple years. If you would like to tackle this task, I would be happy to help.

[kzu]

You mean all massive sponsors (all 11 of them!) paying likely hefty $2/mo isn't enough for you to fix this RIGHT NOW?!?! 🤭

Chiming in to add some perspective on the backs-compat requirement: I use the theme via jekyll-remote-theme and users can point to either main/master or a particular tag very easily to pin the version they are using. (i.e. remote_theme: daattali/[email protected]).

So, if anything breaks badly for them, you can just suggest they pin the version and go on their merry way. Otherwise, they can invest a bit too in upgrading when there are breaking changes.

I think this splits the work more fairly between you as the project author/maintainer and them as the consumers. I don't think it's reasonable to expect full backs-compat for free when there's such an easy mechanism to avoid hitting breaking changes in the first place.

My 2cents. Thanks for the cool theme. I just sent a couple PRs with minor things.

[jjshoe]

I made a simple feature request, it seems to morphed into personal agendas. Closing this out as I found a theme using v5.

[ReenigneArcher]

There's an open PR (#1375) for this repo to add this. It's in final review stages.

[daattali]

Everyone here has just been expressing their feedback in a respectful way, I don't feel anyone was unreasonable. As @ReenigneArcher said, this is going to be added soon (thanks @ReenigneArcher )