Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry tracing integration #520

Open
XiNiHa opened this issue Sep 24, 2024 · 6 comments
Open

Sentry tracing integration #520

XiNiHa opened this issue Sep 24, 2024 · 6 comments

Comments

@XiNiHa
Copy link
Contributor

XiNiHa commented Sep 24, 2024

There are various Sentry integrations for SPA routers with tracing support, a TanStack Router integration for example. Having one for Stackflow would be very helpful for Sentry users.
Since we already have event-driven plugin architecture, I guess it'd be pretty straightforward to make a plugin for it.

@tonyfromundefined
Copy link
Member

Thanks for the great suggestion Xiniha!

I've had a quick look at it, but I'm not sure what the benefits of integrating router framework with Sentry would be. It looks like it adds navigation tracing, but would that be a big help in tracking errors?

https://github.com/getsentry/sentry-javascript/blob/de9cf8a30b61c652264610a31d0c8322748cb46d/packages/react/src/tanstackrouter.ts#L78-L85

@XiNiHa
Copy link
Contributor Author

XiNiHa commented Sep 28, 2024

I believe it can be helpful for both performance monitoring and debugging.

  • Tracking routing and dataloading performances would be important to understand overall performance characteristics of application.
  • While debugging, it's quite useful to know which route a user was on. However, the builtin tracing feature of Sentry relies on History API tracking and therefore doesn't work well with Stackflow - especially when history sync extension is not / can't be used.

@tonyfromundefined
Copy link
Member

tonyfromundefined commented Oct 2, 2024

Okay, that makes sense now that I understand the situation “history sync extension can't be used”. I think it's a good suggestion, and since we don't have the resources right now, I'd be happy if you could contribute to it yourself

@XiNiHa
Copy link
Contributor Author

XiNiHa commented Oct 2, 2024

I'll look into it when I get some spare time 😅 If anyone is interested in the feature, let me know so I can bump up the priority!

@ysh4296
Copy link

ysh4296 commented Nov 12, 2024

@XiNiHa @tonyfromundefined

Hello! im interested in this issue

I already made minimal version of sentry plugin for stackflow and tested it with local server & sentry. seems working properly!

  • error logging
  • url navigation logging
  • pageload transaction logging

If no one else is currently working on this issue can i try this feature?

@XiNiHa
Copy link
Contributor Author

XiNiHa commented Nov 12, 2024

Sounds great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants