Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/keycloak #36

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Feature/keycloak #36

merged 3 commits into from
Oct 10, 2023

Conversation

kristoff-kiefer
Copy link
Contributor

@kristoff-kiefer kristoff-kiefer commented Oct 10, 2023 •
edited
Loading

Description

Links to Tickets or other pull requests

Changes

Changed the organization of helm charts.

  • The keycloak is now an optional (turned on via the values.yaml) sub-dependency of the dbiam-server chart
  • Additionally whether or not an ingress will be provided can be configured separately

Fixed a grammar error in the PR-Template. Information is uncountable, hence "much" not "many"

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

@kristoff-kiefer kristoff-kiefer enabled auto-merge (squash) October 10, 2023 06:34
@kristoff-kiefer kristoff-kiefer merged commit 3a06a97 into main Oct 10, 2023
9 checks passed
@kristoff-kiefer kristoff-kiefer deleted the feature/keycloak branch October 10, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WahlMartin WahlMartin WahlMartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristoff-kiefer @WahlMartin