-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support d3.drag in testing environments #89
Comments
penx
added a commit
to penx/d3-drag
that referenced
this issue
Jan 27, 2023
Return early from nodrag if no view is passed. Fixes d3#89
penx
added a commit
to penx/d3-drag
that referenced
this issue
Jan 27, 2023
Return early from nodrag if no view is passed. Fixes d3#89
penx
added a commit
to penx/d3-drag
that referenced
this issue
Jan 27, 2023
Return early from nodrag if no view is passed. Fixes d3#89
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As per the report in #79 which was closed without a fix.
If using d3-drag in a non browser environment, such as jest + testing-library, an error will be thrown:
This comes from
d3-drag/src/drag.js
Lines 50 to 63 in c6a7e46
d3-drag/src/nodrag.js
Lines 4 to 5 in c6a7e46
Because
view
is null.Downstream issues:
I think nodrag should return early if view is null:
...at least, this works for my use case. I'll raise a PR.
The text was updated successfully, but these errors were encountered: