Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Many warnings #46

Open
RuhiRG opened this issue Jun 30, 2024 · 0 comments
Open

BLD: Many warnings #46

RuhiRG opened this issue Jun 30, 2024 · 0 comments

Comments

@RuhiRG
Copy link
Member

RuhiRG commented Jun 30, 2024

While building for pyseams:

 {aka 'const long unsigned int'} [-Wsign-compare]
   79 |       if (pos == std::string::npos)
      |           ~~~~^~~~~~~~~~~~~~~~~~~~
../subprojects/seams-core/src/topo_one_dim.cpp: In function 'std::vector<int> ring::findPrisms(std::vector<std::vector<int> >, std::vector<strucType>*, int*, int*, std::vector<std::vector<int> >, molSys::PointCloud<molSys::Point<double>, double>*, std::vector<double>*, bool)':
../subprojects/seams-core/src/topo_one_dim.cpp:316:16: warning: unused variable 'isKnownPrism' [-Wunused-variable]
  316 |           bool isKnownPrism = match::matchPrism(
      |                ^~~~~~~~~~~~
../subprojects/seams-core/src/topo_one_dim.cpp: In function 'bool ring::discardExtraTetragonBlocks(std::vector<int>*, std::vector<int>*, molSys::PointCloud<molSys::Point<double>, double>*)':
../subprojects/seams-core/src/topo_one_dim.cpp:494:10: warning: unused variable 'r_i' [-Wunused-variable]
  494 |   double r_i, r_j; // Coordinates in the axial dimension of iatom and jatom of
      |          ^~~
../subprojects/seams-core/src/topo_one_dim.cpp:494:15: warning: unused variable 'r_j' [-Wunused-variable]
  494 |   double r_i, r_j; // Coordinates in the axial dimension of iatom and jatom of
      |               ^~~
../subprojects/seams-core/src/topo_one_dim.cpp: In function 'int ring::assignPrismType(std::vector<std::vector<int> >, std::vector<int>, int, std::vector<strucType>, std::vector<int>*, std::vector<strucType>*)':
../subprojects/seams-core/src/topo_one_dim.cpp:712:21: warning: comparison of integer expressions of different signedness: 'int' and 'std::vector<int>::size_type' {aka 'long unsigned int'} [-Wsign-compare]
  712 |   for (int i = 0; i < listPrism.size(); i++) {
      |                   ~~^~~~~~~~~~~~~~~~~~
[22/26] Compiling C++ object subprojects/seams-core/libyodaLib.so.p/src_topo_two_dim.cpp.o
In file included from ../subprojects/seams-core/src/include/internal/seams_output.hpp:21,
                 from ../subprojects/seams-core/src/include/internal/ring.hpp:33,
                 from ../subprojects/seams-core/src/include/internal/order_parameter.hpp:32,
                 from ../subprojects/seams-core/src/include/internal/topo_two_dim.hpp:31,
                 from ../subprojects/seams-core/src/topo_two_dim.cpp:1:
../subprojects/seams-core/src/include/internal/generic.hpp: In function 'std::array<double, 3> gen::relDist(molSys::PointCloud<molSys::Point<double>, double>*, int, int)':
../subprojects/seams-core/src/include/internal/generic.hpp:204:10: warning: unused variable 'r2' [-Wunused-variable]
  204 |   double r2 = 0.0; // Squared absolute distance

From here. Would be nice for this to be cleaned up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant