Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix support for django_db for celery backend (specially for django… #74

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Hotfix support for django_db for celery backend (specially for django… #74

wants to merge 3 commits into from

Conversation

aidin-leo
Copy link

@aidin-leo aidin-leo commented Jan 8, 2021 •
edited
Loading

suggestion to fix this issue

@EJH2 EJH2 requested a review from OmarWKH January 9, 2021 01:58
@czue
Copy link
Owner

czue commented Jan 9, 2021

Thanks for the contribution! I'll let @OmarWKH weigh in on this change as I'm not familiar with this part of the code

@OmarWKH
Copy link
Collaborator

OmarWKH commented Jan 11, 2021

I'm also not familiar enough with channels.

Initial thoughts:

  1. How does this affect users of other backends?
  2. Should we use database_sync_to_async instead?

I might look into it more later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarWKH OmarWKH Awaiting requested review from OmarWKH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatible with django_celery_results
3 participants
@aidin-leo @czue @OmarWKH