Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External links should load in external browser #7

Closed
GoogleCodeExporter opened this issue Aug 28, 2015 · 4 comments
Closed

External links should load in external browser #7

GoogleCodeExporter opened this issue Aug 28, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

When there is an external link on a page we should not load it
in our application's browser control, it should load in system's
default browser.

In our application's web-browser control we should allow loading only
urls starting with http://127.0.0.1:54007/.

Maybe we should allow to customize this behavior, a list of urls
that should be allowed to load in web-browser control and all
others should be run in system's default browser.

Original issue reported on code.google.com by [email protected] on 13 Jan 2013 at 3:04

@GoogleCodeExporter
Copy link
Author

To have this feature in IE we will have to attach to click
events, see an implementation in 5 Minute Break application:

http://code.google.com/p/5minutebreak/source/browse/WebBrowser/ClickEvents.h

Original comment by [email protected] on 13 Jan 2013 at 3:22

@GoogleCodeExporter
Copy link
Author

A form with external link as an action should also be handled
in a similar fashion.

Original comment by [email protected] on 13 Jan 2013 at 3:25

@GoogleCodeExporter
Copy link
Author

Fixed in revision 413292251313, will appear in version v4.

Original comment by [email protected] on 14 Jan 2013 at 8:01

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Project will move to Github. Find this issue at the new address (soon): 
https://github.com/cztomczak/phpdesktop/issues/7

Original comment by [email protected] on 24 Aug 2015 at 3:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant