Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend pinning cytominer-database to v0.3.3 to avoid unexpected behaviors #136

Open
gwaybio opened this issue Oct 10, 2024 · 4 comments

Comments

@gwaybio
Copy link
Member

gwaybio commented Oct 10, 2024

A quick note to mention that @d33bs and I needed to perform two hotfixes of cytominer-database versions (v0.3.5) to accommodate pycytominer upload to conda-forge. You can see the change in #134

[Dave, please correct me if I’m wrong] If you have cytominer-database pipelines we recommend pinning to v0.3.3.

We aren’t quite there yet, but we also envision sunsetting cytominer-database in pycytominer in the near future, given cytominer-database deprecation and the steady march of python version EOLs.

cc @shntnu @bethac07

@shntnu
Copy link
Member

shntnu commented Oct 10, 2024

We aren’t quite there yet, but we also envision sunsetting cytominer-database in pycytominer in the near future, given cytominer-database deprecation and the steady march of python version EOLs.

IIUC that would mean deprecating collate but nothing else, correct?

@gwaybio
Copy link
Member Author

gwaybio commented Oct 10, 2024

We'll pull out cytominer-database entirely (which I believe only includes collate, yes). We haven't decided when, but when we do, earlier pycytominer versions (at least <=1.2.0) will continue to support.

It's probably a good idea to continue this conversation over in cytomining/pycytominer#202

@d33bs
Copy link
Member

d33bs commented Oct 10, 2024

[Dave, please correct me if I’m wrong] If you have cytominer-database pipelines we recommend pinning to v0.3.3.

I think pinning to v0.3.4 or v0.3.3 would be a good idea. We plan for v0.3.5 to merge changes from v0.3.4 with the master branch (#135) and also drop support for backports.tempfile (#134).

@d33bs
Copy link
Member

d33bs commented Oct 13, 2024

Related note: cytominer-database v0.3.5 is now released on PyPI and conda-forge.

@d33bs d33bs pinned this issue Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants