Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileNotFoundError when scanning path that doesn't exist #5087

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

MetRonnie
Copy link
Member

Fixes bug introduced by #5028 where trying to call cylc clean with a workflow that doesn't exist would throw traceback. Also running cylc scan if you didn't have a ~/cylc-run dir would also throw traceback.

Follow-up to #5065, supersedes #5082

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Tests are included
  • No changelog entry (follow-up to unreleased PR)
  • No docs needed
  • Does not need 8.0.x PR as this bug is on master only

@MetRonnie MetRonnie added the bug Something is wrong :( label Aug 18, 2022
@MetRonnie MetRonnie added this to the cylc-8.1.0 milestone Aug 18, 2022
@MetRonnie MetRonnie self-assigned this Aug 18, 2022
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers.

@hjoliver hjoliver merged commit 38c932e into cylc:master Aug 18, 2022
@MetRonnie MetRonnie deleted the scandir branch August 19, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants