Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method setrestorer doesn't check function on exist #864

Open
afalaleev opened this issue Aug 12, 2019 · 0 comments
Open

Method setrestorer doesn't check function on exist #864

afalaleev opened this issue Aug 12, 2019 · 0 comments
Labels
Low

Comments

@afalaleev
Copy link
Contributor

Description
It is possible to pass not-existing function (for example sin) to setrestorer:

golos.contracts/golos.charge/golos.charge.cpp

Line 94 in 22523f1

void charge::setrestorer(symbol_code token_code, uint8_t charge_id, std::string func_str,

As result, each call of func_str will fail with assert.

Decision
Add testing run with null-values
@afalaleev afalaleev changed the title Method setrestorer doesn't check function of exist Method setrestorer doesn't check function on exist Aug 12, 2019
@afalaleev afalaleev added the Low label Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@afalaleev