Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement tests for delegators #705

Open
s-medvedev opened this issue Jun 13, 2019 · 0 comments
Open

Improvement tests for delegators #705

s-medvedev opened this issue Jun 13, 2019 · 0 comments
Labels
Low
Milestone
Sprint-aug-05

Comments

@s-medvedev
Copy link
Contributor

Tests written in #685 has disadvantages:

  1. Magic-number in users;
  2. Check for balance great then instead of specific values (see also https://github.com/GolosChain/golos.contracts/pull/685/files#r289346472). The model has a reward calculation, but it would be useful in several cases to check users balance for specific values (to check the model too).
@s-medvedev s-medvedev added this to the Sprint-jun-10 milestone Jun 13, 2019
@s-medvedev s-medvedev added the Low label Jun 14, 2019
@kudzinp kudzinp self-assigned this Jul 2, 2019
kudzinp added a commit that referenced this issue Jul 8, 2019
@kudzinp
improvement tests for delegators #705
edb4546
kudzinp added a commit that referenced this issue Jul 8, 2019
@kudzinp
improvement tests for delegators #705
669f780 
updated #705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Low
Projects
None yet
Milestone
Sprint-aug-05
Development

No branches or pull requests
2 participants
@kudzinp @s-medvedev