Api overhaul #87

Sebbben · 2024-10-29T19:28:53Z

No description provided.

Related to cybernetisk#42 We risk issues when name is long or if the user has multiple first names ("Per Ole Hansen" will be shown as "Per" and not "Per Ole")

Remove hard width limit for the LoginButton text, allow the Grid containing LoginButton to shrink to the appropriate size for the length of the text inside LoginButton

Awaits prismaRequest, then reloads the entire page. This 1) confirms to the user that something happened, and 2) updates AppBar to ensure the first name is always correct. I could not get router.refresh() to work, so window.location.reload() is the best replacement I could find.

First name instead of 'Profile' in right corner of header

Manually replaces "About CYB" with "About" on mobile

commit 0f096c0 Merge: a1ce2ec 4dfd6f8 Author: Tepohe <[email protected]> Date: Thu Oct 10 14:42:19 2024 +0200 Merge branch 'main' into development commit a1ce2ec Merge: 4f7d813 f06a472 Author: Tepohe <[email protected]> Date: Tue Oct 8 13:53:44 2024 +0200 Merge branch 'pr/53' into development commit f06a472 Author: Sebbben <[email protected]> Date: Mon Oct 7 16:47:03 2024 +0200 Fixed wrong path for nav bar home from pointing to /home to pointing to / commit 0d154f5 Author: Sebbben <[email protected]> Date: Thu Sep 26 14:40:51 2024 +0200 Renamed some directories to take advantage of nexts routing for more usable url paths Co-Authored-By: Sebbben <[email protected]>

commit d26bd3f Merge: 0f096c0 c019c46 Author: Eric Svebakk <[email protected]> Date: Thu Oct 10 16:54:40 2024 +0200 Merge pull request cybernetisk#67 from Sebbben/fixNoResultMembershipSearch Fix no result membership search commit c019c46 Author: Sebbben <[email protected]> Date: Sat Oct 5 16:20:01 2024 +0200 Made tables turn to first page when the table content changes with a search commit 0f096c0 Merge: a1ce2ec 4dfd6f8 Author: Tepohe <[email protected]> Date: Thu Oct 10 14:42:19 2024 +0200 Merge branch 'main' into development commit a1ce2ec Merge: 4f7d813 f06a472 Author: Tepohe <[email protected]> Date: Tue Oct 8 13:53:44 2024 +0200 Merge branch 'pr/53' into development commit f06a472 Author: Sebbben <[email protected]> Date: Mon Oct 7 16:47:03 2024 +0200 Fixed wrong path for nav bar home from pointing to /home to pointing to / commit 0d154f5 Author: Sebbben <[email protected]> Date: Thu Sep 26 14:40:51 2024 +0200 Renamed some directories to take advantage of nexts routing for more usable url paths Co-Authored-By: Sebbben <[email protected]>

commit f0bacbb Merge: d26bd3f d198b94 Author: Eric Svebakk <[email protected]> Date: Thu Oct 17 15:46:05 2024 +0200 Merge pull request cybernetisk#75 from Borgarsy/feature-halloween-theme Temporary Halloween theme commit d26bd3f Merge: 0f096c0 c019c46 Author: Eric Svebakk <[email protected]> Date: Thu Oct 10 16:54:40 2024 +0200 Merge pull request cybernetisk#67 from Sebbben/fixNoResultMembershipSearch Fix no result membership search commit c019c46 Author: Sebbben <[email protected]> Date: Sat Oct 5 16:20:01 2024 +0200 Made tables turn to first page when the table content changes with a search commit 0f096c0 Merge: a1ce2ec 4dfd6f8 Author: Tepohe <[email protected]> Date: Thu Oct 10 14:42:19 2024 +0200 Merge branch 'main' into development commit d198b94 Author: Borgar <[email protected]> Date: Tue Oct 8 15:01:29 2024 +0200 adds halloween theme. commit a1ce2ec Merge: 4f7d813 f06a472 Author: Tepohe <[email protected]> Date: Tue Oct 8 13:53:44 2024 +0200 Merge branch 'pr/53' into development commit f06a472 Author: Sebbben <[email protected]> Date: Mon Oct 7 16:47:03 2024 +0200 Fixed wrong path for nav bar home from pointing to /home to pointing to / commit 0d154f5 Author: Sebbben <[email protected]> Date: Thu Sep 26 14:40:51 2024 +0200 Renamed some directories to take advantage of nexts routing for more usable url paths Co-Authored-By: Borgarsy <[email protected]>

commit 8b529ef Author: Tepohe <[email protected]> Date: Thu Oct 17 16:20:05 2024 +0200 Updated incorrect url-path commit 73999a8 Merge: f0bacbb 1861431 Author: Eric Svebakk <[email protected]> Date: Thu Oct 17 16:11:36 2024 +0200 git push origin developmentMerge branch 'Sebbben-featureBetterRegisterFeedback' into development Handled merge-conflict for pr/64 commit 1861431 Merge: f0bacbb cd922ac Author: Tepohe <[email protected]> Date: Thu Oct 17 16:08:02 2024 +0200 Handled merge-conflict commit f0bacbb Merge: d26bd3f d198b94 Author: Eric Svebakk <[email protected]> Date: Thu Oct 17 15:46:05 2024 +0200 Merge pull request cybernetisk#75 from Borgarsy/feature-halloween-theme Temporary Halloween theme commit cd922ac Author: Sebbben <[email protected]> Date: Fri Oct 11 10:20:45 2024 +0200 made it so that pressing enter on signin and register page submits the forms commit 56dc570 Author: Sebbben <[email protected]> Date: Fri Oct 11 10:16:44 2024 +0200 removed duplicate login button on successfull registration commit d26bd3f Merge: 0f096c0 c019c46 Author: Eric Svebakk <[email protected]> Date: Thu Oct 10 16:54:40 2024 +0200 Merge pull request cybernetisk#67 from Sebbben/fixNoResultMembershipSearch Fix no result membership search commit c019c46 Author: Sebbben <[email protected]> Date: Sat Oct 5 16:20:01 2024 +0200 Made tables turn to first page when the table content changes with a search commit 0f096c0 Merge: a1ce2ec 4dfd6f8 Author: Tepohe <[email protected]> Date: Thu Oct 10 14:42:19 2024 +0200 Merge branch 'main' into development commit d198b94 Author: Borgar <[email protected]> Date: Tue Oct 8 15:01:29 2024 +0200 adds halloween theme. commit a1ce2ec Merge: 4f7d813 f06a472 Author: Tepohe <[email protected]> Date: Tue Oct 8 13:53:44 2024 +0200 Merge branch 'pr/53' into development commit f06a472 Author: Sebbben <[email protected]> Date: Mon Oct 7 16:47:03 2024 +0200 Fixed wrong path for nav bar home from pointing to /home to pointing to / commit a715fac Author: Sebbben <[email protected]> Date: Tue Oct 1 17:24:53 2024 +0200 added snackbar to singin page commit 6322071 Merge: 131cc76 ea38e61 Author: Sebbben <[email protected]> Date: Tue Oct 1 17:08:07 2024 +0200 Merged features from featureBetterRegisterFeedback into changes made by pvk05's fixRegisterUserResponse commit 131cc76 Merge: 221a968 eb8b2f2 Author: Philip Knudsen <[email protected]> Date: Tue Oct 1 16:32:52 2024 +0200 Merge branch 'cybernetisk:main' into fixRegisterUserResponse commit 221a968 Author: pvk05 <[email protected]> Date: Sat Sep 28 00:57:24 2024 +0200 moved register response to a snackbar for better visual feedback commit ea38e61 Author: Sebbben <[email protected]> Date: Fri Sep 27 23:41:22 2024 +0200 added loading indicator to singin page as well commit 8a3d2de Author: pvk05 <[email protected]> Date: Fri Sep 27 23:14:48 2024 +0200 checks if email includes "@" before registering user commit 3f547cf Author: pvk05 <[email protected]> Date: Fri Sep 27 22:44:11 2024 +0200 fixed response from sendMail function to send correct feedback when failing commit 0b33808 Author: Sebbben <[email protected]> Date: Thu Sep 26 17:07:50 2024 +0200 visual queue when registering user commit 0d154f5 Author: Sebbben <[email protected]> Date: Thu Sep 26 14:40:51 2024 +0200 Renamed some directories to take advantage of nexts routing for more usable url paths Co-Authored-By: Philip Knudsen <[email protected]> Co-Authored-By: Sebbben <[email protected]>

commit cbe876a Merge: 8b529ef ac17a6e Author: Eric Svebakk <[email protected]> Date: Mon Oct 28 16:24:24 2024 +0100 Merge pull request cybernetisk#82 from Sebbben/moveBoardPage Move board page commit ac17a6e Author: Sebbben <[email protected]> Date: Fri Oct 25 10:54:13 2024 +0200 moved pages/main/board/* to (pages)/(main)/board commit 8b529ef Author: Tepohe <[email protected]> Date: Thu Oct 17 16:20:05 2024 +0200 Updated incorrect url-path commit 73999a8 Merge: f0bacbb 1861431 Author: Eric Svebakk <[email protected]> Date: Thu Oct 17 16:11:36 2024 +0200 git push origin developmentMerge branch 'Sebbben-featureBetterRegisterFeedback' into development Handled merge-conflict for pr/64 commit 1861431 Merge: f0bacbb cd922ac Author: Tepohe <[email protected]> Date: Thu Oct 17 16:08:02 2024 +0200 Handled merge-conflict commit f0bacbb Merge: d26bd3f d198b94 Author: Eric Svebakk <[email protected]> Date: Thu Oct 17 15:46:05 2024 +0200 Merge pull request cybernetisk#75 from Borgarsy/feature-halloween-theme Temporary Halloween theme commit cd922ac Author: Sebbben <[email protected]> Date: Fri Oct 11 10:20:45 2024 +0200 made it so that pressing enter on signin and register page submits the forms commit 56dc570 Author: Sebbben <[email protected]> Date: Fri Oct 11 10:16:44 2024 +0200 removed duplicate login button on successfull registration commit d26bd3f Merge: 0f096c0 c019c46 Author: Eric Svebakk <[email protected]> Date: Thu Oct 10 16:54:40 2024 +0200 Merge pull request cybernetisk#67 from Sebbben/fixNoResultMembershipSearch Fix no result membership search commit c019c46 Author: Sebbben <[email protected]> Date: Sat Oct 5 16:20:01 2024 +0200 Made tables turn to first page when the table content changes with a search commit 0f096c0 Merge: a1ce2ec 4dfd6f8 Author: Tepohe <[email protected]> Date: Thu Oct 10 14:42:19 2024 +0200 Merge branch 'main' into development commit d198b94 Author: Borgar <[email protected]> Date: Tue Oct 8 15:01:29 2024 +0200 adds halloween theme. commit a1ce2ec Merge: 4f7d813 f06a472 Author: Tepohe <[email protected]> Date: Tue Oct 8 13:53:44 2024 +0200 Merge branch 'pr/53' into development commit f06a472 Author: Sebbben <[email protected]> Date: Mon Oct 7 16:47:03 2024 +0200 Fixed wrong path for nav bar home from pointing to /home to pointing to / commit a715fac Author: Sebbben <[email protected]> Date: Tue Oct 1 17:24:53 2024 +0200 added snackbar to singin page commit 6322071 Merge: 131cc76 ea38e61 Author: Sebbben <[email protected]> Date: Tue Oct 1 17:08:07 2024 +0200 Merged features from featureBetterRegisterFeedback into changes made by pvk05's fixRegisterUserResponse commit 131cc76 Merge: 221a968 eb8b2f2 Author: Philip Knudsen <[email protected]> Date: Tue Oct 1 16:32:52 2024 +0200 Merge branch 'cybernetisk:main' into fixRegisterUserResponse commit 221a968 Author: pvk05 <[email protected]> Date: Sat Sep 28 00:57:24 2024 +0200 moved register response to a snackbar for better visual feedback commit ea38e61 Author: Sebbben <[email protected]> Date: Fri Sep 27 23:41:22 2024 +0200 added loading indicator to singin page as well commit 8a3d2de Author: pvk05 <[email protected]> Date: Fri Sep 27 23:14:48 2024 +0200 checks if email includes "@" before registering user commit 3f547cf Author: pvk05 <[email protected]> Date: Fri Sep 27 22:44:11 2024 +0200 fixed response from sendMail function to send correct feedback when failing commit 0b33808 Author: Sebbben <[email protected]> Date: Thu Sep 26 17:07:50 2024 +0200 visual queue when registering user commit 0d154f5 Author: Sebbben <[email protected]> Date: Thu Sep 26 14:40:51 2024 +0200 Renamed some directories to take advantage of nexts routing for more usable url paths Co-Authored-By: Sebbben <[email protected]>

… require user to be logged inn

pvk05

some small changes needed, but almost complete

pvk05 · 2024-11-11T14:04:09Z

app/(pages)/(main)/admin/middleware.js

@@ -0,0 +1,5 @@
+import { NextResponse } from "next/server";
+
+export async function middleware(req) {


remove unused function

pvk05 · 2024-11-11T14:07:34Z

app/(pages)/(main)/layout.js

@@ -28,7 +28,7 @@ const NavItems = [
  },
 ];

-export default function AppLayout({ children }) {
+export default async function AppLayout({ children }) {


remove async from client component

pvk05 · 2024-11-11T14:09:03Z

app/(pages)/(main)/middleware.js

remove unused middleware function

pvk05 · 2024-11-11T14:10:46Z

app/(pages)/(main)/profile/page.js

-
+  const handleUpdateData = async () => {
+
+    await fetch(`/api/v2/users/${session.data.user.id}`, {


rewrite to use fetch.then

pvk05 · 2024-11-11T14:11:08Z

app/(pages)/(main)/profile/page.js

-        data: {
-          recruitedById: selectedRecruiter.id,
-        },
+    await fetch(`/api/v2/users/${session.data.user.id}`, {


rewrite to fetch.then

pvk05 · 2024-11-11T14:29:33Z

middleware.js

remove unused middleware

pvk05 · 2024-11-11T14:30:35Z

app/middleware/prisma/prismaRequest.js

pvk05 · 2024-11-11T14:40:24Z

app/api/middleware.js

remove unused

pvk05 · 2024-11-11T17:07:37Z

app/api/utils/auth.js

+     * @param {string[]} requiredRoles List of roles required to access page, pass empty list to require user to be logged in
+     * @returns {Auth}
+    */
+    requireRoles(requiredRoles) {


maybe add admin bypass

pvk05 · 2024-11-11T17:10:53Z

app/api/v2/users/[userID]/route.js

+    const authCheck = new Auth(session)
+    .requireRoles([])
+
+    authCheck.requireOwnership(userID)


could this be chained?

… feature

… to the page

…deafult case

yrjarv and others added 24 commits September 20, 2024 11:12

Replace "Profile" with first section of user name

1948d7a

Related to cybernetisk#42 We risk issues when name is long or if the user has multiple first names ("Per Ole Hansen" will be shown as "Per" and not "Per Ole")

Allow width of LoginButton to be automatic

9cfb39e

Remove hard width limit for the LoginButton text, allow the Grid containing LoginButton to shrink to the appropriate size for the length of the text inside LoginButton

Enable shortening of first name in profile button

3ac806f

Added force-graph logic

9056baf

Reduce max first name length in profile button to 15

4e18084

Replace hyphens in first name with non-breaking hyphen

0b9a317

Merge pull request cybernetisk#44 from yrjarv/main

cee4b41

First name instead of 'Profile' in right corner of header

Manually replaces "About CYB" with "About" on mobile

99e5190

Audited mui version

2c516d4

Update development.yml

15dc90b

Merge branch 'feature-recruitment-graph' into development

0972970

Merge branch 'development'

eb8b2f2

Merge pull request cybernetisk#58 from yrjarv/shorter-about-mobile

4f7d813

Manually replaces "About CYB" with "About" on mobile

Merge branch 'development'

4dfd6f8

updated api to include api version in path

9440123

updated all links to use new api path

fad4284

beginning of api rewrite

c77a94a

logs

9e9ae13

Sebbben self-assigned this Oct 29, 2024

EricSvebakk linked an issue Oct 29, 2024 that may be closed by this pull request

Refactor PrismaRequest middleware #35

Open

Sebbben changed the base branch from main to development October 29, 2024 20:01

EricSvebakk force-pushed the development branch from 0ac7911 to e1a1bed Compare October 30, 2024 10:06

Sebbben added 2 commits October 30, 2024 11:30

admin page converted to new api

fa72104

middleware proof of concept

ab2adb6

Sebbben added 12 commits November 7, 2024 13:54

role based and param based auth added to all api endpoints

5201382

workaround for chaining with async functions not working properly

e40ccd6

fixed roles not showing on profile page

22a378d

fixed some roles but that was introduced with slimming of session object

35962f6

fix for half-chaining requirements

eabcbd6

swithced back to chaining syntax, but made entire auth class non-async

f466be2

replaced relative imports of authOptions for absolute import

b59a8eb

added ownership requirement to updating user userinfo

2384869

fixed edgecase in require ownership if session is null

edd075d

admin buypass on ownership requirements

af8200f

Auth util documentation updated

83f5056

updated access to semester and semesterVolunteerInfo endpoints to not…

81e8920

… require user to be logged inn

pvk05 reviewed Nov 11, 2024

View reviewed changes

fixed issues pointed out by pvk05's review

f02aa36

Sebbben marked this pull request as ready for review November 11, 2024 19:58

Sebbben requested a review from EricSvebakk November 11, 2024 19:59

Sebbben added 10 commits November 12, 2024 15:44

removed last middleware file

22335f0

merged dev into featureBranch for fast forward merge when integrating…

6861a17

… feature

fixed unmerged conflicts and removed middleware.js

9546e15

changed api auth to only require one of the given roles to get access…

b71fa04

… to the page

fixed issue with switch case missing breaks so all requests returned …

c53b2ed

…deafult case

fixed problems with setting roles

c1e1300

fixed issues with headers in customtabes on admin page

b6209d7

changed default filter on logs table on admin page

dc4e9fd

removed intern role for accessing endoints

23799d5

fixed board page to not include orphans

2009232

Sebbben merged commit 2009232 into cybernetisk:development Nov 15, 2024

Sebbben temporarily deployed to ISV2 deployment November 15, 2024 17:47 — with GitHub Actions Inactive

Sebbben temporarily deployed to ISV2 deployment November 18, 2024 11:15 — with GitHub Actions Inactive

Sebbben temporarily deployed to ISV2 deployment November 18, 2024 11:34 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Api overhaul #87

Api overhaul #87

Sebbben commented Oct 29, 2024

pvk05 left a comment

pvk05 Nov 11, 2024

pvk05 Nov 11, 2024

pvk05 Nov 11, 2024

pvk05 Nov 11, 2024

pvk05 Nov 11, 2024

pvk05 Nov 11, 2024

pvk05 Nov 11, 2024

pvk05 Nov 11, 2024

pvk05 Nov 11, 2024

pvk05 Nov 11, 2024

		@@ -0,0 +1,5 @@
		import { NextResponse } from "next/server";

		export async function middleware(req) {


		const handleUpdateData = async () => {

		await fetch(`/api/v2/users/${session.data.user.id}`, {

Api overhaul #87

Api overhaul #87

Conversation

Sebbben commented Oct 29, 2024

pvk05 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment